X-Original-To: pgsql-patches-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [200.46.204.144]) by svr1.postgresql.org (Postfix) with ESMTP id 903D6D1B1BE for ; Mon, 19 Jul 2004 00:13:59 -0300 (ADT) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024) with ESMTP id 01999-08 for ; Mon, 19 Jul 2004 03:13:54 +0000 (GMT) Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by svr1.postgresql.org (Postfix) with ESMTP id 51955D1B16E for ; Mon, 19 Jul 2004 00:13:53 -0300 (ADT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.12.11/8.12.11) with ESMTP id i6J3DokD008193; Sun, 18 Jul 2004 23:13:50 -0400 (EDT) To: Simon Riggs Cc: Bruce Momjian , pgsql-patches@postgresql.org Subject: Re: [HACKERS] Point in Time Recovery In-reply-to: <1090182052.17493.18904.camel@stromboli> References: <200407172015.i6HKFLK17349@candle.pha.pa.us> <25995.1090127083@sss.pgh.pa.us> <1090182052.17493.18904.camel@stromboli> Comments: In-reply-to Simon Riggs message dated "Sun, 18 Jul 2004 21:20:52 +0100" Date: Sun, 18 Jul 2004 23:13:50 -0400 Message-ID: <8192.1090206830@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: by amavisd-new at hub.org X-Spam-Status: No, hits=0.0 tagged_above=0.0 required=5.0 tests= X-Spam-Level: X-Archive-Number: 200407/296 X-Sequence-Number: 11966 Simon Riggs writes: > When archiver starts the FIRST thing it does is run a test to confirm > that the command string works, so setting archive_command to '' would > simply generate an error. No, it would do no such thing; the test cannot really tell anything more than whether system("foo") returns zero ... and at least on my machine, system("") returns zero. It certainly does not prove that any data went to anyplace safe. I diked that test out of the committed patch because I felt it cluttered the archive area without actually proving anything of interest. We can revisit the point if you like. > Also, I would suggest this: > - changing archive mode requires a postmaster restart Why? > - changing archive command should just be a SIGHUP... Check, as committed [and tested to work...] regards, tom lane