X-Original-To: pgsql-admin-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [200.46.204.144]) by svr1.postgresql.org (Postfix) with ESMTP id 5F550D1B1C8 for ; Wed, 30 Jun 2004 11:58:48 -0300 (ADT) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024) with ESMTP id 14718-01 for ; Wed, 30 Jun 2004 14:58:47 +0000 (GMT) Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by svr1.postgresql.org (Postfix) with ESMTP id 71F92D1B193 for ; Wed, 30 Jun 2004 11:58:43 -0300 (ADT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.12.11/8.12.11) with ESMTP id i5UEwjcM008888; Wed, 30 Jun 2004 10:58:45 -0400 (EDT) To: Peter Eisentraut Cc: Simon Riggs , pgsql-admin@postgresql.org Subject: Re: PITR Error Message assistance In-reply-to: <200406300849.18058.peter_e@gmx.net> References: <200406291036.48477.josh@agliodbs.com> <1088541547.3266.7534.camel@stromboli> <200406300849.18058.peter_e@gmx.net> Comments: In-reply-to Peter Eisentraut message dated "Wed, 30 Jun 2004 08:49:18 +0200" Date: Wed, 30 Jun 2004 10:58:44 -0400 Message-ID: <8886.1088607524@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: by amavisd-new at hub.org X-Spam-Status: No, hits=0.0 tagged_above=0.0 required=5.0 tests= X-Spam-Level: X-Archive-Number: 200406/397 X-Sequence-Number: 14057 Peter Eisentraut writes: > Simon Riggs wrote: >> + elog(WARNING, "could not set notify for archiver to read log file >> %u, segment %u", > Reason? (disk full, network down, leap year?) > I think elog() calls don't get translated. You should always use > ereport. Tom would know more about the distinction. elog is deprecated except for debugging or "can't-happen" messages. Anything user-facing ought to be reported with ereport. In this case elog might be okay --- it's not clear to me from this snippet whether the condition is one a user would be likely to see. There's plenty of detail about all this in chapter 45 of the docs: http://www.postgresql.org/docs/7.4/static/source.html and I think most of Peter's comments trace directly to items in the message style guide there. regards, tom lane