Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (1.0)
Subject: Re: Upgrading 9.6.9 to 10.4
From: John Scalia <jayknowsunix@gmail.com>
In-Reply-To: <20180711163633.GL23217@nighthawk.caipicrew.dd-dns.de>
Date: Wed, 11 Jul 2018 12:54:26 -0400
Cc: David Morton <david.morton@eroad.com>,
 "pgsql-admin@lists.postgresql.org" <pgsql-admin@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <E8CB52F6-7A4E-4871-9668-80A9C0867D14@gmail.com>
References: <8D4726EE-74E8-494B-9ED1-817EF2BB5E4B@gmail.com>
 <55998B04-BB01-45F9-B478-BCE1DA4E8E6E@eroad.com>
 <67BBE981-45B6-4CC8-BA3C-DF9210D46D8F@gmail.com>
 <20180711163633.GL23217@nighthawk.caipicrew.dd-dns.de>
To: Michael Banck <michael.banck@credativ.de>
Precedence: bulk

Tried several branches including the one you specified. None of them mention=
ed the newly revised PostgreSQL functions that were causing the compilation t=
o break. I did manage to alter the code so it will now build with either 9.6=
 or the 10.4 instance. Was just sharing my experience as it was certainly br=
oken prior.

Sent from my iPhone

> On Jul 11, 2018, at 12:36 PM, Michael Banck <michael.banck@credativ.de> wr=
ote:
>=20
> Hi John,
>=20
>> On Wed, Jun 27, 2018 at 03:53:20PM -0400, John Scalia wrote:
>> Ok, I figured out why the Makefile is broken for pglogical for
>> PostgreSQL V.10. The pg_config utility returned 10.4 for the line
>> setting Makefile parameter PGVER. Adding a simple =E2=80=9C| cut -c1-2 to=
 that
>> line allows the Makefile to run for 9.6 and 10.4, probably other
>> versions as well.
>=20
> (10.4 isn't a major version, it's the fourth minor/patch release of the
> v10 major version).
>=20
> If you don't have the `| cut -c 1-2' in your Makefile then you're
> probably looking at the wrong branch, the pglogical master branch on
> github is stale, you need (for reasons that escape me) the REL2_x_STABLE
> branch. Or probably the 2.2.0 release tarball would work just as fine.
>=20
>> There are compile problems, however, in several source files. I don=E2=80=
=99t
>> have the code in front of me, but one doing heap work calls
>> replorigin_drop with a single argument, but that changed in V10 to
>> need 2 args. Fairly easy to fix that one.
>>=20
>> Another source calls ExecARUpdateTriggers, and its friends Insert and
>> Delete, those signatures have changed as well, and I haven=E2=80=99t yet
>> figured out how to alter pglogical for compiling these.
>=20
> I assume those failues are addressed in the above branch/release as
> well, but I have not verified that.
>=20
>=20
> Cheers
>=20
> Michael
>=20
> --=20
> Michael Banck
> Projektleiter / Senior Berater
> Tel.: +49 2166 9901-171
> Fax:  +49 2166 9901-100
> Email: michael.banck@credativ.de
>=20
> credativ GmbH, HRB M=C3=B6nchengladbach 12080
> USt-ID-Nummer: DE204566209
> Trompeterallee 108, 41189 M=C3=B6nchengladbach
> Gesch=C3=A4ftsf=C3=BChrung: Dr. Michael Meskes, J=C3=B6rg Folz, Sascha Heu=
er
>=20
> Unser Umgang mit personenbezogenen Daten unterliegt
> folgenden Bestimmungen: https://www.credativ.de/datenschutz