Date: Wed, 11 May 2022 14:34:25 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Magnus Hagander <magnus@hagander.net>,
	"Bossart, Nathan" <bossartn@amazon.com>,
	Fujii Masao <masao.fujii@oss.nttdata.com>,
	Justin Pryzby <pryzby@telsasoft.com>,
	Andres Freund <andres@anarazel.de>,
	Mark Dilger <mark.dilger@enterprisedb.com>,
	Don Seiler <don@seiler.us>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Estimating HugePages Requirements?
Message-ID: <YntK4a8ET4dW0E4L@paquier.xyz>
References: <Yjq9bJe28newGZaK@paquier.xyz>
 <CABUevEyExSDrtZ4wU19iX4yvgExR1EpjFKB4ExFQDgTAvAHFyg@mail.gmail.com>
 <Yl8z169DzkSjdZFV@paquier.xyz>
 <CABUevEwPPxR-SD55UWDLZuLa2UVGY+OQpVPPvO82X10MU_hLcA@mail.gmail.com>
 <YmXoIEaR2CWRV7KP@paquier.xyz>
 <CABUevEyD_aLM=oXi1jj8hRN=7aJq--jN4FP+ehY8Vu60+QH61A@mail.gmail.com>
 <YmdMDiCCyVJLlB/F@paquier.xyz>
 <20220506171318.GA3448558@nathanxps13>
 <Yni6ZHkGotUU+RSf@paquier.xyz>
 <20220510161249.GA3715618@nathanxps13>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="gJiJGd16PX/VVc8f"
Content-Disposition: inline
In-Reply-To: <20220510161249.GA3715618@nathanxps13>
Archived-At: 
 <https://www.postgresql.org/message-id/YntK4a8ET4dW0E4L%40paquier.xyz>
Precedence: bulk


--gJiJGd16PX/VVc8f
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, May 10, 2022 at 09:12:49AM -0700, Nathan Bossart wrote:
> AFAICT you need to set log_min_messages to at least DEBUG3 to see extra
> output for the non-runtime-computed GUCs, so it might not be worth the
> added complexity.

This set of messages is showing up for ages with zero complaints from
the field AFAIK, and nobody would use this level of logging except
developers.  One thing that overriding log_min_messages to FATAL does,
however, is to not show anymore those debug3 messages when querying a
runtime-computed GUC, but that's the kind of things we'd hide.  Your
patch would hide those entries in both cases.  Perhaps we could do
that, but at the end, I don't really see any need to complicate this
code path more than necessary, and this is enough to silence the logs
in the cases we care about basically all the time, even if the log
levels are reduced a bit on a given cluster.  Hence, I have applied
the simplest solution to just enforce a log_min_messages=FATAL when
requesting a runtime GUC.
--
Michael

--gJiJGd16PX/VVc8f
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmJ7SuEACgkQnvQgOdby
QH1FXg/9FOT49562VMoIPChHstO2aIkX0SNvEukjNDqKY4E3wqXnLogvhGoBhH1y
5x2/vpTC862DrNZj+Xt34hgD8QKMd1S8N7lo+7MJ+0N6wSDuW96vyLp8AWhb3Sag
m2eDSzmVSIixAFK0FtTEjERHAYa3iMzIpyJQWN0xqDuOViHZQO9nr526jfvbV4bn
tUWg3wjDsRz062N9YDz+3wykJCfpAAnWBgaUllafPqG8COaqJHuXCT/6QSxkPlPB
AVuoKFOoNklfpTWwPYloIph2JW4QxaLbtWABjeUaKnvfIIDWVmvAwNi/pKw4JHkv
3Oc06LizfGwI6IKduE07Pr+nTfn3Mxv+0crcFogriNOhQbhl70fh3li0uWSB41nR
q/juPpSoSZKi3vMR6blTOP2M/lYZfgWppeBdj9XbhAvfdD/7LVO5pHn70rW0N3d+
9xE2QT+LS2+V2zi3T0PRkfjWBUbr4Cjayrzdz66XHuj0deunLuX74O7WA79BYu5p
/hqc7+A7pMafpaYU8zKoSkgMzH+L0tkskWqbTH9QYG/h4BReoVetx8WrVCT/PFmN
/c5b5ZgCQRLcqBLi0luWvYkPM+ii5gN9yXXY4FDhad935coYlTb1eN8ThtH/kepm
QVgjTytP1GY5lCtajQG6kKVe4I84xma9SvGeYqOq7+oEpxMLShE=
=vn94
-----END PGP SIGNATURE-----

--gJiJGd16PX/VVc8f--