pg.ddx.io pgsql-admin@postgresql.org mailing list archive
help / color / mirror / Atom feedAdding more detail to pg_upgrade documentation
8+ messages / 3 participants
[nested] [flat]
Commits from this thread:
2022-07-14 47ae6948f0 27b8f73fd3 a36882ef94 b0ea3e46c6 2d4c6437c8 e24ea2a97f 0d8db8cf85 pg_upgrade doc: mention that replication slots must be recreated
* Adding more detail to pg_upgrade documentation
@ 2022-05-27 18:41 Nikhil Shetty <nikhil.dba04@gmail.com>
0 siblings, 2 replies; 8+ messages in thread
From: Nikhil Shetty @ 2022-05-27 18:41 UTC (permalink / raw)
To: Pgsql-admin <pgsql-admin@lists.postgresql.org>
Hi,
We are upgrading from Postgres 11 to 13. During upgrade we found that the
physical slots on the old cluster are not copied to the new cluster.
This information is not mentioned in the documentation -
https://www.postgresql.org/docs/13/pgupgrade.html
Just thought it would be good to have this detail
Thanks and Regards,
Nikhil
^ permalink raw reply [nested|flat] 8+ messages in thread
* Fwd: Adding more detail to pg_upgrade documentation
@ 2022-05-31 15:28 Nikhil Shetty <nikhil.dba04@gmail.com>
parent: Nikhil Shetty <nikhil.dba04@gmail.com>
1 sibling, 1 reply; 8+ messages in thread
From: Nikhil Shetty @ 2022-05-31 15:28 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org
Hi,
We are upgrading from Postgres 11 to 13. During upgrade we found that the
physical slots on the old cluster are not copied to the new cluster.
This information is not mentioned in the documentation -
https://www.postgresql.org/docs/13/pgupgrade.html
Just thought it would be good to have this detail
Thanks and Regards,
Nikhil
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Fwd: Adding more detail to pg_upgrade documentation
@ 2022-06-03 20:18 Jack DeVries <jdevries3133@gmail.com>
parent: Nikhil Shetty <nikhil.dba04@gmail.com>
0 siblings, 1 reply; 8+ messages in thread
From: Jack DeVries @ 2022-06-03 20:18 UTC (permalink / raw)
To: Nikhil Shetty <nikhil.dba04@gmail.com>; +Cc: pgsql-docs@lists.postgresql.org
Hi Nikhil,
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Fwd: Adding more detail to pg_upgrade documentation
@ 2022-06-04 09:38 Nikhil Shetty <nikhil.dba04@gmail.com>
parent: Jack DeVries <jdevries3133@gmail.com>
0 siblings, 1 reply; 8+ messages in thread
From: Nikhil Shetty @ 2022-06-04 09:38 UTC (permalink / raw)
To: Jack DeVries <jdevries3133@gmail.com>; +Cc: pgsql-docs@lists.postgresql.org
Hi Jack,
I followed the same steps multiple times but each time, slot had to be
recreated.
The slots under directory pg_replslot are not created in the new cluster
during pg_upgrade.
Thanks and Regards,
Nikhil
On Sat, 4 Jun 2022 at 1:48 AM, Jack DeVries <jdevries3133@gmail.com> wrote:
> Hi Nikhil,
>
> From the pgupgrade docs:
>
> > 9. Prepare for standby server upgrades
> >
> > If you are upgrading standby servers using methods outlined in section
> > Step 11, verify that the old standby servers are caught up by running
> > pg_controldata against the old primary and standby clusters. Verify
> > that the “Latest checkpoint location” values match in all clusters.
> > (There will be a mismatch if old standby servers were shut down before
> > the old primary or if the old standby servers are still running.)
> > Also, make sure wal_level is not set to minimal in the postgresql.conf
> > file on the new primary cluster.
>
> (source: https://www.postgresql.org/docs/devel/pgupgrade.html)
>
> I'm a new contributor so please forgive me if I'm on the wrong track,
> but if you follow this step, won't you also be ensuring that replication
> slots do not need to be migrated, since you've just ensured that standby
> clusters are in sync with the primary cluster? Please let me know if I'm
> missing anything!
>
> Thank You,
> Jack DeVries
>
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Fwd: Adding more detail to pg_upgrade documentation
@ 2022-07-10 02:38 Bruce Momjian <bruce@momjian.us>
parent: Nikhil Shetty <nikhil.dba04@gmail.com>
0 siblings, 1 reply; 8+ messages in thread
From: Bruce Momjian @ 2022-07-10 02:38 UTC (permalink / raw)
To: Nikhil Shetty <nikhil.dba04@gmail.com>; +Cc: Jack DeVries <jdevries3133@gmail.com>; pgsql-docs@lists.postgresql.org
On Sat, Jun 4, 2022 at 03:08:58PM +0530, Nikhil Shetty wrote:
> Hi Jack,
>
> I followed the same steps multiple times but each time, slot had to be
> recreated.
>
> The slots under directory pg_replslot are not created in the new cluster during
> pg_upgrade.
>
> Thanks and Regards,
> Nikhil
>
> On Sat, 4 Jun 2022 at 1:48 AM, Jack DeVries <jdevries3133@gmail.com> wrote:
>
> Hi Nikhil,
>
> >From the pgupgrade docs:
>
> > 9. Prepare for standby server upgrades
> >
> > If you are upgrading standby servers using methods outlined in section
> > Step 11, verify that the old standby servers are caught up by running
> > pg_controldata against the old primary and standby clusters. Verify
> > that the “Latest checkpoint location” values match in all clusters.
> > (There will be a mismatch if old standby servers were shut down before
> > the old primary or if the old standby servers are still running.)
> > Also, make sure wal_level is not set to minimal in the postgresql.conf
> > file on the new primary cluster.
>
> (source: https://www.postgresql.org/docs/devel/pgupgrade.html)
>
> I'm a new contributor so please forgive me if I'm on the wrong track,
> but if you follow this step, won't you also be ensuring that replication
> slots do not need to be migrated, since you've just ensured that standby
> clusters are in sync with the primary cluster? Please let me know if I'm
> missing anything!
I have written the attached patch to document this.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Indecision is a decision. Inaction is an action. Mark Batterson
Attachments:
slots.diff (text/x-diff, 679B) download
diff --git a/doc/src/sgml/ref/pgupgrade.sgml b/doc/src/sgml/ref/pgupgrade.sgml
index f3eb7fbd33..d065227656 100644
--- a/doc/src/sgml/ref/pgupgrade.sgml
+++ b/doc/src/sgml/ref/pgupgrade.sgml
@@ -619,7 +619,8 @@ rsync --archive --delete --hard-links --size-only --no-inc-recursive /vol1/pg_tb
Configure the servers for log shipping. (You do not need to run
<function>pg_backup_start()</function> and <function>pg_backup_stop()</function>
or take a file system backup as the standbys are still synchronized
- with the primary.)
+ with the primary.) Replication slots are not copied and must
+ be recreated.
</para>
</step>
* Re: Fwd: Adding more detail to pg_upgrade documentation
@ 2022-07-14 20:34 Bruce Momjian <bruce@momjian.us>
parent: Bruce Momjian <bruce@momjian.us>
0 siblings, 1 reply; 8+ messages in thread
From: Bruce Momjian @ 2022-07-14 20:34 UTC (permalink / raw)
To: Nikhil Shetty <nikhil.dba04@gmail.com>; +Cc: Jack DeVries <jdevries3133@gmail.com>; pgsql-docs@lists.postgresql.org
On Sat, Jul 9, 2022 at 10:38:30PM -0400, Bruce Momjian wrote:
> > (source: https://www.postgresql.org/docs/devel/pgupgrade.html)
> >
> > I'm a new contributor so please forgive me if I'm on the wrong track,
> > but if you follow this step, won't you also be ensuring that replication
> > slots do not need to be migrated, since you've just ensured that standby
> > clusters are in sync with the primary cluster? Please let me know if I'm
> > missing anything!
>
> I have written the attached patch to document this.
Patch applied to all supported versions.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Indecision is a decision. Inaction is an action. Mark Batterson
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Fwd: Adding more detail to pg_upgrade documentation
@ 2022-07-15 15:57 Nikhil Shetty <nikhil.dba04@gmail.com>
parent: Bruce Momjian <bruce@momjian.us>
0 siblings, 0 replies; 8+ messages in thread
From: Nikhil Shetty @ 2022-07-15 15:57 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: Jack DeVries <jdevries3133@gmail.com>; pgsql-docs@lists.postgresql.org
Thank you Bruce !
On Fri, 15 Jul 2022 at 2:04 AM, Bruce Momjian <bruce@momjian.us> wrote:
> On Sat, Jul 9, 2022 at 10:38:30PM -0400, Bruce Momjian wrote:
> > > (source: https://www.postgresql.org/docs/devel/pgupgrade.html)
> > >
> > > I'm a new contributor so please forgive me if I'm on the wrong
> track,
> > > but if you follow this step, won't you also be ensuring that
> replication
> > > slots do not need to be migrated, since you've just ensured that
> standby
> > > clusters are in sync with the primary cluster? Please let me know
> if I'm
> > > missing anything!
> >
> > I have written the attached patch to document this.
>
> Patch applied to all supported versions.
>
> --
> Bruce Momjian <bruce@momjian.us> https://momjian.us
> EDB https://enterprisedb.com
>
> Indecision is a decision. Inaction is an action. Mark Batterson
>
>
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Adding more detail to pg_upgrade documentation
@ 2022-08-31 02:08 Bruce Momjian <bruce@momjian.us>
parent: Nikhil Shetty <nikhil.dba04@gmail.com>
1 sibling, 0 replies; 8+ messages in thread
From: Bruce Momjian @ 2022-08-31 02:08 UTC (permalink / raw)
To: Nikhil Shetty <nikhil.dba04@gmail.com>; +Cc: Pgsql-admin <pgsql-admin@lists.postgresql.org>
On Sat, May 28, 2022 at 12:11:31AM +0530, Nikhil Shetty wrote:
> Hi,
>
> We are upgrading from Postgres 11 to 13. During upgrade we found that the
> physical slots on the old cluster are not copied to the new cluster.
>
> This information is not mentioned in the documentation - https://
> www.postgresql.org/docs/13/pgupgrade.html
>
> Just thought it would be good to have this detail
All releases after 2022-07-14 have this mentioned:
commit 47ae6948f0
Author: Bruce Momjian <bruce@momjian.us>
Date: Thu Jul 14 16:34:30 2022 -0400
pg_upgrade doc: mention that replication slots must be recreated
Reported-by: Nikhil Shetty
Discussion: https://postgr.es/m/CAFpL5Vxastip0Jei-K-=7cKXTg=5sahSe5g=om=x68NOX8+PUA@mail.gmail.com
Backpatch-through: 10
So, these releases:
https://www.postgresql.org/about/news/postgresql-145-138-1212-1117-1022-and-15-beta-3-released-2496/
PostgreSQL 14.5, 13.8, 12.12, 11.17, 10.22
See here:
https://www.postgresql.org/docs/15/pgupgrade.html
Section 11.7
--> Replication slots are not copied and must be recreated.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Indecision is a decision. Inaction is an action. Mark Batterson
^ permalink raw reply [nested|flat] 8+ messages in thread
end of thread, other threads:[~2022-08-31 02:08 UTC | newest]
Thread overview: 8+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-05-27 18:41 Adding more detail to pg_upgrade documentation Nikhil Shetty <nikhil.dba04@gmail.com>
2022-05-31 15:28 ` Nikhil Shetty <nikhil.dba04@gmail.com>
2022-06-03 20:18 ` Jack DeVries <jdevries3133@gmail.com>
2022-06-04 09:38 ` Nikhil Shetty <nikhil.dba04@gmail.com>
2022-07-10 02:38 ` Bruce Momjian <bruce@momjian.us>
2022-07-14 20:34 ` Bruce Momjian <bruce@momjian.us>
2022-07-15 15:57 ` Nikhil Shetty <nikhil.dba04@gmail.com>
2022-08-31 02:08 ` Bruce Momjian <bruce@momjian.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox