pg.ddx.io  pgsql-admin@postgresql.org mailing list archive  
help / color / mirror / Atom feed
IMPORTANT: two new PostgreSQL security problems found
6+ messages / 5 participants
[nested] [flat]

* IMPORTANT: two new PostgreSQL security problems found
@ 2005-05-02 20:06  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 2 replies; 6+ messages in thread

From: Tom Lane @ 2005-05-02 20:06 UTC (permalink / raw)
  To: pgsql-announce@postgresql.org

Two serious security errors have been found in PostgreSQL 7.3 and newer
releases.  These errors at least allow an unprivileged database user to
crash the backend process, and may make it possible for an unprivileged
user to gain the privileges of a database superuser.

We are currently preparing new releases that will correct these problems
in freshly initdb'd installations.  However, because these problems are
really incorrect system catalog entries, updating to a new release will
NOT by itself solve the problems in an existing installation.  Instead,
it is necessary for the database administrator to fix the catalog entries
manually, as described below.  We are releasing this advisory to encourage
administrators of PostgreSQL installations to perform these fixes as soon
as possible.


Character conversion vulnerability
----------------------------------

The more severe of the two errors is that the functions that support
client-to-server character set conversion can be called from SQL commands
by unprivileged users, but these functions are not designed to be safe
against malicious choices of argument values.  This problem exists in
PostgreSQL 7.3.* through 8.0.*.  The recommended fix is to disable public
EXECUTE access for these functions.  This does not affect normal usage of
the functions for character set conversion, but it will prevent misuse.

To accomplish this change, execute the following SQL command as a
superuser:

	UPDATE pg_proc SET proacl = '{=}'
	WHERE pronamespace = 11 AND pronargs = 5
	      AND proargtypes[2] = 'cstring'::regtype;

In 7.3.* through 8.0.*, this should report having updated 90 rows.
7.4 and later will report a "WARNING: defaulting grantor to user ID 1"
which can be ignored.

The above command must be carried out in *each* database of an
installation, including template1, and ideally including template0 as
well.  If you do not fix the template databases then any subsequently
created databases will contain the same vulnerability.  template1 can
be fixed in the same way as any other database, but fixing template0
requires additional steps. First, from any database issue

UPDATE pg_database SET datallowconn = true WHERE datname = 'template0';

Next connect to template0 and perform the pg_proc update. Finally, do 

-- re-freeze template0:
VACUUM FREEZE;
-- and protect it against future alterations:
UPDATE pg_database SET datallowconn = false WHERE datname = 'template0';


tsearch2 vulnerability
----------------------

The other error is that the contrib/tsearch2 module misdeclares several
functions as returning type "internal" when they do not have any
"internal" argument.  This breaks the type safety of "internal" by
allowing users to construct SQL commands that invoke other functions
accepting "internal" arguments.  The consequences of this have not been
investigated in detail, but it is certainly at least possible to crash
the backend.

This error affects PostgreSQL 7.4 and later, but only if you have
installed the contrib/tsearch2 module.  The recommended fix is to
change the misdeclared functions so that they accept an "internal"
argument and therefore cannot be called directly from SQL commands.
To do this, execute the following command as a superuser:

	UPDATE pg_proc SET proargtypes[0] = 'internal'::regtype
	WHERE oid IN (
		'dex_init(text)'::regprocedure,
		'snb_en_init(text)'::regprocedure,
		'snb_ru_init(text)'::regprocedure,
		'spell_init(text)'::regprocedure,
		'syn_init(text)'::regprocedure
	);

This should report 5 rows updated.  (If it fails with a message
like "function "dex_init(text)" does not exist", then either tsearch2
is not installed in this database, or you already did the update.)

You will need to do this in *each* database in which you have installed
tsearch2, including template1.  You need not worry about template0,
however, since it will certainly not contain tsearch2.

If you frequently install tsearch2 in new databases, you will also
want to modify the tsearch.sql script to declare these functions as
taking type internal in the first place.  (The script fix will be part
of the upcoming releases, so you may be able to wait for those.)


On behalf of the PostgreSQL core committee, I'd like to apologize for
any problems that may arise from these errors.

			regards, tom lane



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: [ANNOUNCE] IMPORTANT: two new PostgreSQL security problems found
@ 2005-05-02 22:09  Thomas F.O'Connell <tfo@sitening.com>
  parent: Tom Lane <tgl@sss.pgh.pa.us>
  1 sibling, 1 reply; 6+ messages in thread

From: Thomas F.O'Connell @ 2005-05-02 22:09 UTC (permalink / raw)
  To: pgsql-admin; +Cc: pgsql-announce@postgresql.org

Considering that this is a security-related system catalog update, is 
there any way of providing some sort of signature for a message like 
this such that the community can feel that issuing some arcane commands 
as a superuser won't open a hole rather than close one?

This is the first time I've seen an announcement of this sort regarding 
PostgreSQL, and I'm just curious about the release mechanism for it.

I doubt if anyone is spoofing Tom, but in an era of phishing and 
spoofing, one can't be too sure, especially if one is concerned about 
security...

-tfo

--
Thomas F. O'Connell
Co-Founder, Information Architect
Sitening, LLC

Strategic Open Source: Open Your i™

http://www.sitening.com/
110 30th Avenue North, Suite 6
Nashville, TN 37203-6320
615-260-0005

On May 2, 2005, at 3:06 PM, Tom Lane wrote:

> Two serious security errors have been found in PostgreSQL 7.3 and newer
> releases.  These errors at least allow an unprivileged database user to
> crash the backend process, and may make it possible for an unprivileged
> user to gain the privileges of a database superuser.
>
> We are currently preparing new releases that will correct these 
> problems
> in freshly initdb'd installations.  However, because these problems are
> really incorrect system catalog entries, updating to a new release will
> NOT by itself solve the problems in an existing installation.  Instead,
> it is necessary for the database administrator to fix the catalog 
> entries
> manually, as described below.  We are releasing this advisory to 
> encourage
> administrators of PostgreSQL installations to perform these fixes as 
> soon
> as possible.
>
>
> Character conversion vulnerability
> ----------------------------------
>
> The more severe of the two errors is that the functions that support
> client-to-server character set conversion can be called from SQL 
> commands
> by unprivileged users, but these functions are not designed to be safe
> against malicious choices of argument values.  This problem exists in
> PostgreSQL 7.3.* through 8.0.*.  The recommended fix is to disable 
> public
> EXECUTE access for these functions.  This does not affect normal usage 
> of
> the functions for character set conversion, but it will prevent misuse.
>
> To accomplish this change, execute the following SQL command as a
> superuser:
>
> 	UPDATE pg_proc SET proacl = '{=}'
> 	WHERE pronamespace = 11 AND pronargs = 5
> 	      AND proargtypes[2] = 'cstring'::regtype;
>
> In 7.3.* through 8.0.*, this should report having updated 90 rows.
> 7.4 and later will report a "WARNING: defaulting grantor to user ID 1"
> which can be ignored.
>
> The above command must be carried out in *each* database of an
> installation, including template1, and ideally including template0 as
> well.  If you do not fix the template databases then any subsequently
> created databases will contain the same vulnerability.  template1 can
> be fixed in the same way as any other database, but fixing template0
> requires additional steps. First, from any database issue
>
> UPDATE pg_database SET datallowconn = true WHERE datname = 'template0';
>
> Next connect to template0 and perform the pg_proc update. Finally, do
>
> -- re-freeze template0:
> VACUUM FREEZE;
> -- and protect it against future alterations:
> UPDATE pg_database SET datallowconn = false WHERE datname = 
> 'template0';
>
>
> tsearch2 vulnerability
> ----------------------
>
> The other error is that the contrib/tsearch2 module misdeclares several
> functions as returning type "internal" when they do not have any
> "internal" argument.  This breaks the type safety of "internal" by
> allowing users to construct SQL commands that invoke other functions
> accepting "internal" arguments.  The consequences of this have not been
> investigated in detail, but it is certainly at least possible to crash
> the backend.
>
> This error affects PostgreSQL 7.4 and later, but only if you have
> installed the contrib/tsearch2 module.  The recommended fix is to
> change the misdeclared functions so that they accept an "internal"
> argument and therefore cannot be called directly from SQL commands.
> To do this, execute the following command as a superuser:
>
> 	UPDATE pg_proc SET proargtypes[0] = 'internal'::regtype
> 	WHERE oid IN (
> 		'dex_init(text)'::regprocedure,
> 		'snb_en_init(text)'::regprocedure,
> 		'snb_ru_init(text)'::regprocedure,
> 		'spell_init(text)'::regprocedure,
> 		'syn_init(text)'::regprocedure
> 	);
>
> This should report 5 rows updated.  (If it fails with a message
> like "function "dex_init(text)" does not exist", then either tsearch2
> is not installed in this database, or you already did the update.)
>
> You will need to do this in *each* database in which you have installed
> tsearch2, including template1.  You need not worry about template0,
> however, since it will certainly not contain tsearch2.
>
> If you frequently install tsearch2 in new databases, you will also
> want to modify the tsearch.sql script to declare these functions as
> taking type internal in the first place.  (The script fix will be part
> of the upcoming releases, so you may be able to wait for those.)
>
>
> On behalf of the PostgreSQL core committee, I'd like to apologize for
> any problems that may arise from these errors.
>
> 			regards, tom lane
>
> ---------------------------(end of 
> broadcast)---------------------------
> TIP 7: don't forget to increase your free space map settings




^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: [ANNOUNCE] IMPORTANT: two new PostgreSQL security problems
@ 2005-05-03 03:08  Tatsuo Ishii <t-ishii@sra.co.jp>
  parent: Tom Lane <tgl@sss.pgh.pa.us>
  1 sibling, 0 replies; 6+ messages in thread

From: Tatsuo Ishii @ 2005-05-03 03:08 UTC (permalink / raw)
  To: pgsql-general@postgresql.org

> Two serious security errors have been found in PostgreSQL 7.3 and newer
> releases.  These errors at least allow an unprivileged database user to
> crash the backend process, and may make it possible for an unprivileged
> user to gain the privileges of a database superuser.
> 
> We are currently preparing new releases that will correct these problems
> in freshly initdb'd installations.  However, because these problems are
> really incorrect system catalog entries, updating to a new release will
> NOT by itself solve the problems in an existing installation.  Instead,
> it is necessary for the database administrator to fix the catalog entries
> manually, as described below.  We are releasing this advisory to encourage
> administrators of PostgreSQL installations to perform these fixes as soon
> as possible.
> 
> 
> Character conversion vulnerability
> ----------------------------------
> 
> The more severe of the two errors is that the functions that support
> client-to-server character set conversion can be called from SQL commands
> by unprivileged users, but these functions are not designed to be safe
> against malicious choices of argument values.  This problem exists in
> PostgreSQL 7.3.* through 8.0.*.  The recommended fix is to disable public
> EXECUTE access for these functions.  This does not affect normal usage of
> the functions for character set conversion, but it will prevent misuse.
[snip]

I apologize as the original developer for CREATE CONVERSION. I should
have made these functions only accessible by privileged users when I
developed it.
--
Tatsuo Ishii



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: [ANNOUNCE] IMPORTANT: two new PostgreSQL security problems found
@ 2005-05-04 23:44  Greg Sabino Mullane <greg@turnstep.com>
  parent: Thomas F.O'Connell <tfo@sitening.com>
  0 siblings, 0 replies; 6+ messages in thread

From: Greg Sabino Mullane @ 2005-05-04 23:44 UTC (permalink / raw)
  To: pgsql-admin


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


> Considering that this is a security-related system catalog update, is
> there any way of providing some sort of signature for a message like
> this such that the community can feel that issuing some arcane commands
> as a superuser won't open a hole rather than close one?
  
An excellent point. Ideally someone (Tom) would be using GnuPG to sign
important messages like this with a digital signature. However, there are
a few checks one could do until that happens. One, compare his headers with
previous ones. Second, check the page at www.postgresql.org for a matching
announcement. Third, wait five minutes for the real Tom Lane to denounce any
fake email sent in his name. :)

If it makes you feel better, I'm 100% sure that was a legitimate email, and
I am going to sign this. :)

- --
Greg Sabino Mullane greg@turnstep.com
PGP Key: 0x14964AC8 200505040739
http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8

-----BEGIN PGP SIGNATURE-----

iD8DBQFCeLTwvJuQZxSWSsgRAtACAKDvyylXy1MliqSs8Jsoz7XicXmBagCgoprg
qKPTIVv55E3ne19OGvtOTHM=
=IFvp
-----END PGP SIGNATURE-----





^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: IMPORTANT: two new PostgreSQL security problems found
@ 2005-05-09 19:30  Thomas F.O'Connell <tfo@sitening.com>
  0 siblings, 1 reply; 6+ messages in thread

From: Thomas F.O'Connell @ 2005-05-09 19:30 UTC (permalink / raw)
  To: pgsql-admin

I put together a little Perl script (which assumes proper installation 
of both DBI and DBD::Pg and that template1 exists) that takes care of 
the character conversion vulnerability:

http://www.sitening.com/postgresql-update-2005-1

I've run this on my development servers, and it seems to have had the 
anticipated effect, but, as always, more eyeballs help. If anyone notes 
any potential showstoppers, I'll gladly update the script.

I don't have tsearch2 installed anywhere, so I didn't bother with that, 
but this script could probably be easily modified to address that 
vulnerability.

-tfo

--
Thomas F. O'Connell
Co-Founder, Information Architect
Sitening, LLC

Strategic Open Source: Open Your i™

http://www.sitening.com/
110 30th Avenue North, Suite 6
Nashville, TN 37203-6320
615-260-0005



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: IMPORTANT: two new PostgreSQL security problems found
@ 2005-05-14 23:00  Tomaz Borstnar <tomaz.borstnar@over.net>
  parent: Thomas F.O'Connell <tfo@sitening.com>
  0 siblings, 0 replies; 6+ messages in thread

From: Tomaz Borstnar @ 2005-05-14 23:00 UTC (permalink / raw)
  To: pgsql-admin

Thomas F.O'Connell wrote:
> I put together a little Perl script (which assumes proper installation 
> of both DBI and DBD::Pg and that template1 exists) that takes care of 
> the character conversion vulnerability:

dont hardcode pgsql superuser :)

Tomaž



^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2005-05-14 23:00 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2005-05-02 20:06 IMPORTANT: two new PostgreSQL security problems found Tom Lane <tgl@sss.pgh.pa.us>
2005-05-02 22:09 ` Thomas F.O'Connell <tfo@sitening.com>
2005-05-04 23:44   ` Greg Sabino Mullane <greg@turnstep.com>
2005-05-03 03:08 ` Re: [ANNOUNCE] IMPORTANT: two new PostgreSQL security problems Tatsuo Ishii <t-ishii@sra.co.jp>
2005-05-09 19:30 Re: IMPORTANT: two new PostgreSQL security problems found Thomas F.O'Connell <tfo@sitening.com>
2005-05-14 23:00 ` Tomaz Borstnar <tomaz.borstnar@over.net>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox