To: pgsql-admin@postgresql.org
From: Christian Ullrich <chris@chrullrich.net>
Subject: Problem with pg_upgrade 9.2 on Windows
Date: Thu, 13 Sep 2012 14:15:00 +0200
Lines: 79
Message-ID: <k2sio4$dqg$1@ger.gmane.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
	rv:15.0) Gecko/20120824 Thunderbird/15.0

Hello all,

I get the following output from pg_upgrade when trying to upgrade a
test cluster on Windows 7 x64:

c:\Daten>path
PATH=c:\windows;c:\windows\system32;c:\Program Files\PostgreSQL\9.2\bin

c:\Daten>pg_upgrade --old-bindir="c:\Program Files\PostgreSQL\9.1\bin"
--new-bindir="c:\Program Files\PostgreSQL\9.2\bin"
--old-datadir="c:\Daten\db\pgsql"
--new-datadir=c:\Daten\db\pgsql-9.2\data --old-port=5432
--new-port=5433 --user=postgres --verbose --check

[...]

Checking for contrib/isn with bigint-passing mismatch       ok
""c:\Program Files\PostgreSQL\9.1\bin/pg_ctl" -w -D
"c:\Daten\db\pgsql" -o ""  stop >> "pg_upgrade_utility.log" 2>&1"
pg_ctl: no operation specified
Try "pg_ctl --help" for more information.
*failure*
There were problems executing """c:\Program
Files\PostgreSQL\9.1\bin/pg_ctl" -w -D "c:\Daten\db\pgsql" -o ""  stop
>> "pg_upgrade_utility.log" 2>&1""

Consult the last few lines of "pg_upgrade_utility.log" for
the probable cause of the failure.
Failure, exiting
""c:\Program Files\PostgreSQL\9.1\bin/pg_ctl" -w -D
"c:\Daten\db\pgsql" -o "" -m fast stop >> "pg_upgrade_utility.log" 2>&1"
pg_ctl: no operation specified
Try "pg_ctl --help" for more information.
*failure*
There were problems executing """c:\Program
Files\PostgreSQL\9.1\bin/pg_ctl" -w -D "c:\Daten\db\pgsql" -o "" -m
fast stop >> "pg_upgrade_utility.log"
2>&1""
Consult the last few lines of "pg_upgrade_utility.log" for
the probable cause of the failure.


If needed, I can provide the full output of pg_upgrade, but it does
not indicate any other problems.

Man's best friend, procmon, shows the following command lines for the
last three invocations of pg_ctl:

"c:\Program Files\PostgreSQL\9.1\bin/pg_ctl" -w -l
"pg_upgrade_server.log" -D "c:\Daten\db\pgsql" -o "-p 5432 -b " start

"c:\Program Files\PostgreSQL\9.1\bin/pg_ctl" -w -D "c:\Daten\db\pgsql"
-o "  stop >> "pg_upgrade_utility.log" 2>&1"

"c:\Program Files\PostgreSQL\9.1\bin/pg_ctl" -w -D "c:\Daten\db\pgsql"
-o " -m fast stop >> "pg_upgrade_utility.log" 2>&1"


As you can see, the two failing commands (the last two) are missing
the second quote for the empty -o option. This pulled the remainder of
the command line, including the operation and the output redirection,
into the -o option's value. The output from pg_upgrade itself, as well
as the referenced log file (see below) have such an unintelligible
mess of quotation marks that I cannot tell whether it's correct there.

pg_upgrade_utility.log:

command: ""c:\Program Files\PostgreSQL\9.1\bin/pg_ctl" -w -D
"c:\Daten\db\pgsql" -o ""  stop >> "pg_upgrade_utility.log" 2>&1"


command: ""c:\Program Files\PostgreSQL\9.1\bin/pg_ctl" -w -D
"c:\Daten\db\pgsql" -o "" -m fast stop >> "pg_upgrade_utility.log" 2>&1"


Is there anything I can do to avoid this? Should I report it as a bug?

-- 
Christian