Subject: Re: BUG #15565: truncate bug with tables which have temp table
 inherited
References: <15565-ce67a48d0244436a@postgresql.org>
From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Message-ID: <0285c6d1-2d11-2f2c-6fae-d4575cdc3c7b@lab.ntt.co.jp>
Date: Tue, 25 Dec 2018 09:49:43 +0900
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.3
MIME-Version: 1.0
In-Reply-To: <15565-ce67a48d0244436a@postgresql.org>
Content-Type: multipart/mixed;
 boundary="------------F01D26B13FE5F3B7A0D8BA87"
Content-Language: en-US
To: digoal@126.com, pgsql-bugs@lists.postgresql.org,
        PG Bug reporting form <noreply@postgresql.org>
Precedence: bulk

This is a multi-part message in MIME format.
--------------F01D26B13FE5F3B7A0D8BA87
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Hi,

On 2018/12/24 18:17, PG Bug reporting form wrote:
> The following bug has been logged on the website:
> 
> Bug reference:      15565
> Logged by:          Zhou Digoal
> Email address:      digoal@126.com
> PostgreSQL version: 11.1
> Operating system:   CentOS 7.x x64
> Description:        
> 
> ```
> create table public.a (id int);
> ```
> 
> sesssion a:
> 
> ```
> create temp table a (like public.a) inherits(public.a);
> ```
> 
> session b:
> ```
> create temp table a (like public.a) inherits(public.a);
> ```
> 
> any session:
> 
> ```
> postgres=# truncate public.a;
> ERROR:  cannot truncate temporary tables of other sessions
> ```
> 
> but delete,select,update is ok;

I'm not sure if the error being shown is a bug, but maybe we could remove
the error by making truncate do the same thing as select/update/delete,
that is, ignore child tables that are temporary of tables of other
sessions.  Attached patch to do that.

Thanks,
Amit

--------------F01D26B13FE5F3B7A0D8BA87
Content-Type: text/plain; charset=UTF-8;
 name="truncate-ignore-other-session-temp-children.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="truncate-ignore-other-session-temp-children.patch"

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2NvbW1hbmRzL3RhYmxlY21kcy5jIGIvc3JjL2Jh
Y2tlbmQvY29tbWFuZHMvdGFibGVjbWRzLmMKaW5kZXggYWQ4YzE3Njc5My4uOWRhYmZjMGQz
NiAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvY29tbWFuZHMvdGFibGVjbWRzLmMKKysrIGIv
c3JjL2JhY2tlbmQvY29tbWFuZHMvdGFibGVjbWRzLmMKQEAgLTE0MTYsNiArMTQxNiwxOSBA
QCBFeGVjdXRlVHJ1bmNhdGUoVHJ1bmNhdGVTdG10ICpzdG10KQogCiAJCQkJLyogZmluZF9h
bGxfaW5oZXJpdG9ycyBhbHJlYWR5IGdvdCBsb2NrICovCiAJCQkJcmVsID0gaGVhcF9vcGVu
KGNoaWxkcmVsaWQsIE5vTG9jayk7CisKKwkJCQkvKgorCQkJCSAqIEl0IGlzIHBvc3NpYmxl
IHRoYXQgdGhlIHBhcmVudCB0YWJsZSBoYXMgY2hpbGRyZW4gdGhhdCBhcmUgdGVtcAorCQkJ
CSAqIHRhYmxlcyBvZiBvdGhlciBiYWNrZW5kcy4gIFdlIGNhbm5vdCBzYWZlbHkgYWNjZXNz
IHN1Y2ggdGFibGVzCisJCQkJICogKGJlY2F1c2Ugb2YgYnVmZmVyaW5nIGlzc3VlcyksIGFu
ZCB0aGUgYmVzdCB0aGluZyB0byBkbyBzZWVtcworCQkJCSAqIHRvIGJlIHRvIHNpbGVudGx5
IGlnbm9yZSB0aGVtLgorCQkJCSAqLworCQkJCWlmIChSRUxBVElPTl9JU19PVEhFUl9URU1Q
KG5ld3JlbGF0aW9uKSkKKwkJCQl7CisJCQkJCWhlYXBfY2xvc2UocmVsKTsKKwkJCQkJY29u
dGludWU7CisJCQkJfQorCiAJCQkJdHJ1bmNhdGVfY2hlY2tfcmVsKFJlbGF0aW9uR2V0UmVs
aWQocmVsKSwgcmVsLT5yZF9yZWwpOwogCQkJCXRydW5jYXRlX2NoZWNrX2FjdGl2aXR5KHJl
bCk7CiAK
--------------F01D26B13FE5F3B7A0D8BA87--