From: Daniel Gustafsson <daniel@yesql.se>
Message-Id: <057A2AED-0116-446B-8986-57FDA70CA5A3@yesql.se>
Content-Type: multipart/mixed;
	boundary="Apple-Mail=_ED16ABF3-5A50-44A4-A684-F6D579576670"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.2\))
Subject: Re: BUG #19095: Test if function exit() is used fail when linked
 static
Date: Fri, 14 Nov 2025 13:11:15 +0100
In-Reply-To: <aRRCE_2ydBfCnO7Q@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
 BharatDB <bharatdbpg@gmail.com>,
 torsten.rupp@gmx.net,
 pgsql-bugs@lists.postgresql.org,
 VASUKI M <vasukim1992002@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
References: <19095-6d8256d0c37d4be2@postgresql.org>
 <CAAh00ETwx8_AEM0wgoi-v875uC-FLuGGOMTaP9fCNdVw4Zq=Vg@mail.gmail.com>
 <2305435.1762929527@sss.pgh.pa.us>
 <7C7B32ED-5742-49D5-9380-5E02AA5B03C4@yesql.se>
 <aRRCE_2ydBfCnO7Q@paquier.xyz>
Archived-At: <https://www.postgresql.org/message-id/057A2AED-0116-446B-8986-57FDA70CA5A3%40yesql.se>
Precedence: bulk


--Apple-Mail=_ED16ABF3-5A50-44A4-A684-F6D579576670
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

> On 12 Nov 2025, at 09:15, Michael Paquier <michael@paquier.xyz> wrote:
>=20
> On Wed, Nov 12, 2025 at 09:13:09AM +0100, Daniel Gustafsson wrote:
>> On 12 Nov 2025, at 07:38, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> Personally I'm okay with whitelisting pthread_exit() as
>>> Torsten suggested.
>>=20
>> +1, we already have a few whitelisted entries and pthread_exit seems =
perfectly
>> reasonable to add to that list.
>=20
> WFM.

The attached trivial diff adds this to the whitelist clause in the =
Makefile.  I
experimented with adding this to Meson, and while it's trivial enough to =
do the
run_command with libpq_so.full_path, it's less clear to me exactly where =
in the
build it should be added.  I've pinged my colleague Bilal who is much =
better at
Meson than me to collaborate on that as a separate fix.

--
Daniel Gustafsson


--Apple-Mail=_ED16ABF3-5A50-44A4-A684-F6D579576670
Content-Disposition: attachment;
	filename=pthread_exit_whitelist.diff
Content-Type: application/octet-stream;
	x-unix-mode=0644;
	name="pthread_exit_whitelist.diff"
Content-Transfer-Encoding: 7bit

diff --git a/src/interfaces/libpq/Makefile b/src/interfaces/libpq/Makefile
index da6650066d4..3bd0e4f3840 100644
--- a/src/interfaces/libpq/Makefile
+++ b/src/interfaces/libpq/Makefile
@@ -144,7 +144,7 @@ $(stlib): $(OBJS_STATIC)
 libpq-refs-stamp: $(shlib)
 ifneq ($(enable_coverage), yes)
 ifeq (,$(filter solaris,$(PORTNAME)))
-	@if nm -A -u $< 2>/dev/null | grep -v -e __cxa_atexit -e __tsan_func_exit | grep exit; then \
+	@if nm -A -u $< 2>/dev/null | grep -v -e __cxa_atexit -e __tsan_func_exit -e pthread_exit | grep exit; then \
 		echo 'libpq must not be calling any function which invokes exit'; exit 1; \
 	fi
 endif

--Apple-Mail=_ED16ABF3-5A50-44A4-A684-F6D579576670--