Message-ID: <05e57a2122d22962cdd8f344bcb3af7a1e1c487f.camel@j-davis.com>
Subject: Re: ALTER FOREIGN DATA WRAPPER can drop dependency on handler
From: Jeff Davis <pgsql@j-davis.com>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: pgsql-bugs@postgresql.org
Date: Wed, 18 Mar 2026 13:40:38 -0700
In-Reply-To: <abr9Nhe8UOdoN10L@nathan>
References: <35c44a4b7fb76d35418c4d66b775a88f4ce60c86.camel@j-davis.com>
	 <abr9Nhe8UOdoN10L@nathan>
Content-Type: multipart/mixed; boundary="=-kj5+DbeSmu5sFaA/S1Au"
User-Agent: Evolution 3.52.3-0ubuntu1.1 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/05e57a2122d22962cdd8f344bcb3af7a1e1c487f.camel%40j-davis.com>
Precedence: bulk

--=-kj5+DbeSmu5sFaA/S1Au
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2026-03-18 at 14:29 -0500, Nathan Bossart wrote:
> This matches what we do for the validator a few lines down, so it
> makes
> sense to me.=C2=A0 Could it be worth adding a test or two?

Added a test.

Testing in the other direction (adding HANDLER and leaving VALIDATOR
unspecified, then dropping the validator) is slightly more complex
because I don't want to drop the built-in postgresql_fdw_validator. But
the patch in the other thread can be extended with a new test or two
also, which will cover that case.

Will backport all the way.

Regards,
	Jeff Davis


--=-kj5+DbeSmu5sFaA/S1Au
Content-Disposition: attachment; filename="v2-0001-Fix-dependency-on-FDW-handler.patch"
Content-Type: text/x-patch; name="v2-0001-Fix-dependency-on-FDW-handler.patch";
	charset="UTF-8"
Content-Transfer-Encoding: base64

RnJvbSA3ODYyZTE3Mzc0MWRlZTcxNzJiMzgwYzIzYTI0YTA3Y2ZhZGU0MWVmIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKZWZmIERhdmlzIDxqZWZmQGotZGF2aXMuY29tPgpEYXRlOiBX
ZWQsIDE4IE1hciAyMDI2IDExOjUyOjE1IC0wNzAwClN1YmplY3Q6IFtQQVRDSCB2Ml0gRml4IGRl
cGVuZGVuY3kgb24gRkRXIGhhbmRsZXIuCgpBTFRFUiBGT1JFSUdOIERBVEEgV1JBUFBFUiBjb3Vs
ZCBkcm9wIHRoZSBkZXBlbmRlbmN5IG9uIHRoZSBoYW5kbGVyCmZ1bmN0aW9uIGlmIGl0IHdhc24n
dCBleHBsaWNpdGx5IHNwZWNpZmllZC4KClJldmlld2VkLWJ5OiBOYXRoYW4gQm9zc2FydCA8bmF0
aGFuZGJvc3NhcnRAZ21haWwuY29tPgpEaXNjdXNzaW9uOiBodHRwczovL3Bvc3Rnci5lcy9tLzM1
YzQ0YTRiN2ZiNzZkMzU0MThjNGQ2NmI3NzVhODhmNGNlNjBjODYuY2FtZWxAai1kYXZpcy5jb20K
QmFja3BhdGNoLXRocm91Z2g6IDE0Ci0tLQogc3JjL2JhY2tlbmQvY29tbWFuZHMvZm9yZWlnbmNt
ZHMuYyAgICAgICAgIHwgNSArKysrKwogc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9mb3JlaWdu
X2RhdGEub3V0IHwgNyArKysrKysrCiBzcmMvdGVzdC9yZWdyZXNzL3NxbC9mb3JlaWduX2RhdGEu
c3FsICAgICAgfCA1ICsrKysrCiAzIGZpbGVzIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKykKCmRp
ZmYgLS1naXQgYS9zcmMvYmFja2VuZC9jb21tYW5kcy9mb3JlaWduY21kcy5jIGIvc3JjL2JhY2tl
bmQvY29tbWFuZHMvZm9yZWlnbmNtZHMuYwppbmRleCA0NTY4MTIzNTc4Mi4uMGIzMWFmZDhhNzkg
MTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL2NvbW1hbmRzL2ZvcmVpZ25jbWRzLmMKKysrIGIvc3Jj
L2JhY2tlbmQvY29tbWFuZHMvZm9yZWlnbmNtZHMuYwpAQCAtNzg2LDYgKzc4NiwxMSBAQCBBbHRl
ckZvcmVpZ25EYXRhV3JhcHBlcihQYXJzZVN0YXRlICpwc3RhdGUsIEFsdGVyRmR3U3RtdCAqc3Rt
dCkKIAkJZXJlcG9ydChXQVJOSU5HLAogCQkJCShlcnJtc2coImNoYW5naW5nIHRoZSBmb3JlaWdu
LWRhdGEgd3JhcHBlciBoYW5kbGVyIGNhbiBjaGFuZ2UgYmVoYXZpb3Igb2YgZXhpc3RpbmcgZm9y
ZWlnbiB0YWJsZXMiKSkpOwogCX0KKwllbHNlCisJeworCQkvKiBoYW5kbGVyIHVuY2hhbmdlZCAq
LworCQlmZHdoYW5kbGVyID0gZmR3Rm9ybS0+ZmR3aGFuZGxlcjsKKwl9CiAKIAlpZiAodmFsaWRh
dG9yX2dpdmVuKQogCXsKZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvZm9y
ZWlnbl9kYXRhLm91dCBiL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvZm9yZWlnbl9kYXRhLm91
dAppbmRleCA2YWY1NGQ5ODAzZi4uMzVkNzUxODBkZmYgMTAwNjQ0Ci0tLSBhL3NyYy90ZXN0L3Jl
Z3Jlc3MvZXhwZWN0ZWQvZm9yZWlnbl9kYXRhLm91dAorKysgYi9zcmMvdGVzdC9yZWdyZXNzL2V4
cGVjdGVkL2ZvcmVpZ25fZGF0YS5vdXQKQEAgLTEwNiw2ICsxMDYsMTMgQEAgRVJST1I6ICBjb25m
bGljdGluZyBvciByZWR1bmRhbnQgb3B0aW9ucwogTElORSAxOiAuLi5HTiBEQVRBIFdSQVBQRVIg
dGVzdF9mZHcgSEFORExFUiB0ZXN0X2Zkd19oYW5kbGVyIEhBTkRMRVIgaW4uLi4KICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBeCiBD
UkVBVEUgRk9SRUlHTiBEQVRBIFdSQVBQRVIgdGVzdF9mZHcgSEFORExFUiB0ZXN0X2Zkd19oYW5k
bGVyOworLS0gc2hvdWxkIHByZXNlcnZlIGRlcGVuZGVuY3kgb24gdGVzdF9mZHdfaGFuZGxlcgor
QUxURVIgRk9SRUlHTiBEQVRBIFdSQVBQRVIgdGVzdF9mZHcgVkFMSURBVE9SIHBvc3RncmVzcWxf
ZmR3X3ZhbGlkYXRvcjsKK1dBUk5JTkc6ICBjaGFuZ2luZyB0aGUgZm9yZWlnbi1kYXRhIHdyYXBw
ZXIgdmFsaWRhdG9yIGNhbiBjYXVzZSB0aGUgb3B0aW9ucyBmb3IgZGVwZW5kZW50IG9iamVjdHMg
dG8gYmVjb21lIGludmFsaWQKK0RST1AgRlVOQ1RJT04gdGVzdF9mZHdfaGFuZGxlcigpOyAtLSBF
UlJPUgorRVJST1I6ICBjYW5ub3QgZHJvcCBmdW5jdGlvbiB0ZXN0X2Zkd19oYW5kbGVyKCkgYmVj
YXVzZSBvdGhlciBvYmplY3RzIGRlcGVuZCBvbiBpdAorREVUQUlMOiAgZm9yZWlnbi1kYXRhIHdy
YXBwZXIgdGVzdF9mZHcgZGVwZW5kcyBvbiBmdW5jdGlvbiB0ZXN0X2Zkd19oYW5kbGVyKCkKK0hJ
TlQ6ICBVc2UgRFJPUCAuLi4gQ0FTQ0FERSB0byBkcm9wIHRoZSBkZXBlbmRlbnQgb2JqZWN0cyB0
b28uCiBEUk9QIEZPUkVJR04gREFUQSBXUkFQUEVSIHRlc3RfZmR3OwogLS0gQUxURVIgRk9SRUlH
TiBEQVRBIFdSQVBQRVIKIEFMVEVSIEZPUkVJR04gREFUQSBXUkFQUEVSIGZvbyBPUFRJT05TIChu
b25leGlzdGVudCAnZmR3Jyk7ICAgICAgICAgLS0gRVJST1IKZGlmZiAtLWdpdCBhL3NyYy90ZXN0
L3JlZ3Jlc3Mvc3FsL2ZvcmVpZ25fZGF0YS5zcWwgYi9zcmMvdGVzdC9yZWdyZXNzL3NxbC9mb3Jl
aWduX2RhdGEuc3FsCmluZGV4IDA4NGQ1NTU5ZTA5Li4wMDgwYmZiODg1NiAxMDA2NDQKLS0tIGEv
c3JjL3Rlc3QvcmVncmVzcy9zcWwvZm9yZWlnbl9kYXRhLnNxbAorKysgYi9zcmMvdGVzdC9yZWdy
ZXNzL3NxbC9mb3JlaWduX2RhdGEuc3FsCkBAIC02Nyw2ICs2NywxMSBAQCBDUkVBVEUgRlVOQ1RJ
T04gaW52YWxpZF9mZHdfaGFuZGxlcigpIFJFVFVSTlMgaW50IExBTkdVQUdFIFNRTCBBUyAnU0VM
RUNUIDE7JzsKIENSRUFURSBGT1JFSUdOIERBVEEgV1JBUFBFUiB0ZXN0X2ZkdyBIQU5ETEVSIGlu
dmFsaWRfZmR3X2hhbmRsZXI7ICAtLSBFUlJPUgogQ1JFQVRFIEZPUkVJR04gREFUQSBXUkFQUEVS
IHRlc3RfZmR3IEhBTkRMRVIgdGVzdF9mZHdfaGFuZGxlciBIQU5ETEVSIGludmFsaWRfZmR3X2hh
bmRsZXI7ICAtLSBFUlJPUgogQ1JFQVRFIEZPUkVJR04gREFUQSBXUkFQUEVSIHRlc3RfZmR3IEhB
TkRMRVIgdGVzdF9mZHdfaGFuZGxlcjsKKworLS0gc2hvdWxkIHByZXNlcnZlIGRlcGVuZGVuY3kg
b24gdGVzdF9mZHdfaGFuZGxlcgorQUxURVIgRk9SRUlHTiBEQVRBIFdSQVBQRVIgdGVzdF9mZHcg
VkFMSURBVE9SIHBvc3RncmVzcWxfZmR3X3ZhbGlkYXRvcjsKK0RST1AgRlVOQ1RJT04gdGVzdF9m
ZHdfaGFuZGxlcigpOyAtLSBFUlJPUgorCiBEUk9QIEZPUkVJR04gREFUQSBXUkFQUEVSIHRlc3Rf
ZmR3OwogCiAtLSBBTFRFUiBGT1JFSUdOIERBVEEgV1JBUFBFUgotLSAKMi40My4wCgo=


--=-kj5+DbeSmu5sFaA/S1Au--