Subject: Re: printf %s with NULL pointer (was Re: BUG #17098: Assert failed on
 composing an error message when adding a type to an extension being dropped)
To: Tom Lane <tgl@sss.pgh.pa.us>, Ranier Vilela <ranier.vf@gmail.com>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <17098-b960f3616c861f83@postgresql.org>
 <2468663.1626017338@sss.pgh.pa.us> <2984422.1626110456@sss.pgh.pa.us>
 <dc29b1131b84bef879cf68d1d1edae07f51ca3d2.camel@cybertec.at>
 <3227956.1626186568@sss.pgh.pa.us>
 <CAEudQAq22dUhHp9ryKNOnro0HkQWiJE1F3g3VxHUFsqQ4ZkyeA@mail.gmail.com>
 <3280448.1626200778@sss.pgh.pa.us>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Message-ID: <06a9ff0f-d1e9-0340-2f3b-180cefe41c7a@enterprisedb.com>
Date: Wed, 14 Jul 2021 08:05:54 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <3280448.1626200778@sss.pgh.pa.us>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/06a9ff0f-d1e9-0340-2f3b-180cefe41c7a%40enterprisedb.com>
Precedence: bulk

On 13.07.21 20:26, Tom Lane wrote:
> Did you see my followup?  The vast majority of live systems do not do
> that, so we are accomplishing nothing of value by insisting it's a
> crash-worthy bug.

But there are no guarantees that that will be maintained in the future. 
In the past, it has often come back to bite us when we relied on 
implementation-dependent behavior in the C library or the compiler, 
because no optimization might invalidate old assumptions.

In this particular case, I would for example be quite curious how those 
alternative minimal C libraries such as musl-libc handle this.