Subject: Re: BUG #17126: Server crashes on dropping user while enumerating
 owned objects that are droppped concurrently
To: Alvaro Herrera <alvherre@alvh.no-ip.org>, pgsql-bugs@lists.postgresql.org
References: <202107282001.rfd75lew2c33@alvherre.pgsql>
From: Alexander Lakhin <exclusion@gmail.com>
Message-ID: <07fc0336-1b28-8269-d7cc-c34d50c650ce@gmail.com>
Date: Thu, 2 Sep 2021 07:00:01 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <202107282001.rfd75lew2c33@alvherre.pgsql>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Language: ru-RU
Archived-At: 
 <https://www.postgresql.org/message-id/07fc0336-1b28-8269-d7cc-c34d50c650ce%40gmail.com>
Precedence: bulk

Hello Alvaro,
28.07.2021 23:01, Alvaro Herrera wrote:
> On 2021-Jul-28, PG Bug reporting form wrote:
>
>> Dropping a user that owns a number of procedures, while some of them are
>> being dropped, can cause the server crash:
>> There's many places that deal correctly with the possibility that
>> getObjectDescription() would return NULL, but I found two places that
>> don't.
I've found another one in dependency.c:

        else if (behavior == DROP_RESTRICT)
        {
            char       *otherDesc = getObjectDescription(&extra->dependee,
                                                         false);
...
            pfree(otherDesc);
I couldn't trigger a failure at this place yet, but maybe it's worth to
fix here too.

Best regards,
Alexander