Feedback-ID: ie0a040ee:Fastmail
Content-Type: multipart/mixed; boundary="------------IFVrWVNxHn6A09fQ90PMHlPH"
Message-ID: <080afa1e-476b-44f2-b052-4d669c23d290@eisentraut.org>
Date: Tue, 18 Jun 2024 08:25:24 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: BUG #18513: PG17 build on windows generates postgres.exe.lib
 instead of postgres.lib
To: muralikrishna.bandaru@enterprisedb.com, pgsql-bugs@lists.postgresql.org
References: <18513-cf23db54997c9021@postgresql.org>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <18513-cf23db54997c9021@postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/080afa1e-476b-44f2-b052-4d669c23d290%40eisentraut.org>
Precedence: bulk

This is a multi-part message in MIME format.
--------------IFVrWVNxHn6A09fQ90PMHlPH
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 17.06.24 07:44, PG Bug reporting form wrote:
> The following bug has been logged on the website:
> 
> Bug reference:      18513
> Logged by:          Muralikrishna Bandaru
> Email address:      muralikrishna.bandaru@enterprisedb.com
> PostgreSQL version: 17beta1
> Operating system:   Windows
> Description:
> 
> PG17 build on windows is generating postgres.exe.lib. But all the previous
> versions generating postgres.lib file. Due to this renaming the extensions
> fail to link with this library by default as they expect postgres.lib. For
> example here is the link for system_stats project file
> https://github.com/EnterpriseDB/system_stats/blob/master/system_stats.vcxproj#L101
> 
> This seems like a bug, Can some one please confirm?

The attached patch might fix it.  At least I appear to get the right 
output file name.  I don't have the ability to check whether it does the 
right thing on Cygwin.

--------------IFVrWVNxHn6A09fQ90PMHlPH
Content-Type: text/plain; charset=UTF-8;
 name="0001-meson-Fix-import-library-name-in-Windows.patch"
Content-Disposition: attachment;
 filename="0001-meson-Fix-import-library-name-in-Windows.patch"
Content-Transfer-Encoding: base64

RnJvbSAzZTZlZjViYjBkZTZhYTI5MGZiZjUyMjk2ZTViYTU0NGM3MTNmYzY3IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy
YXV0Lm9yZz4KRGF0ZTogVHVlLCAxOCBKdW4gMjAyNCAwODoyMjoxMSArMDIwMApTdWJqZWN0
OiBbUEFUQ0hdIG1lc29uOiBGaXggaW1wb3J0IGxpYnJhcnkgbmFtZSBpbiBXaW5kb3dzCgpU
aGlzIGNoYW5nZXMgdGhlIGltcG9ydCBsaWJyYXJ5IG5hbWUgZnJvbSAncG9zdGdyZXMuZXhl
LmxpYicgdG8KJ3Bvc3RncmVzLmxpYicsIHdoaWNoIGlzIHdoYXQgaXQgd2FzIHdpdGggdGhl
IG9sZCBNU1ZDIGJ1aWxkIHN5c3RlbS4KClhYWCBjaGVjayBjeWd3aW4KCkJ1ZzogIzE4NTEz
ClJlcG9ydGVkLWJ5OiBNdXJhbGlrcmlzaG5hIEJhbmRhcnUgPG11cmFsaWtyaXNobmEuYmFu
ZGFydUBlbnRlcnByaXNlZGIuY29tPgotLS0KIG1lc29uLmJ1aWxkICAgICAgICAgICAgIHwg
NiArKystLS0KIHNyYy9iYWNrZW5kL21lc29uLmJ1aWxkIHwgMiArLQogMiBmaWxlcyBjaGFu
Z2VkLCA0IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbWVz
b24uYnVpbGQgYi9tZXNvbi5idWlsZAppbmRleCAyNzY3YWJkMTllMi4uMDI5MjliYjg0NWYg
MTAwNjQ0Ci0tLSBhL21lc29uLmJ1aWxkCisrKyBiL21lc29uLmJ1aWxkCkBAIC0yMDEsNyAr
MjAxLDcgQEAgaWYgaG9zdF9zeXN0ZW0gPT0gJ2N5Z3dpbicKICAgY3BwZmxhZ3MgKz0gJy1E
X0dOVV9TT1VSQ0UnCiAgIGRsc3VmZml4ID0gJy5kbGwnCiAgIG1vZF9saW5rX2FyZ3NfZm10
ID0gWydAMEAnXQotICBtb2RfbGlua193aXRoX25hbWUgPSAnbGliQDBALmV4ZS5hJworICBt
b2RfbGlua193aXRoX25hbWUgPSAnbGliQDBALmEnCiAgIG1vZF9saW5rX3dpdGhfZGlyID0g
J2xpYmRpcicKIAogZWxpZiBob3N0X3N5c3RlbSA9PSAnZGFyd2luJwpAQCAtMjczLDEwICsy
NzMsMTAgQEAgZWxpZiBob3N0X3N5c3RlbSA9PSAnd2luZG93cycKICAgZXhwb3J0X2ZpbGVf
c3VmZml4ID0gJ2RlZicKICAgaWYgY2MuZ2V0X2lkKCkgPT0gJ21zdmMnCiAgICAgZXhwb3J0
X2ZtdCA9ICcvREVGOkAwQCcKLSAgICBtb2RfbGlua193aXRoX25hbWUgPSAnQDBALmV4ZS5s
aWInCisgICAgbW9kX2xpbmtfd2l0aF9uYW1lID0gJ0AwQC5saWInCiAgIGVsc2UKICAgICBl
eHBvcnRfZm10ID0gJ0AwQCcKLSAgICBtb2RfbGlua193aXRoX25hbWUgPSAnbGliQDBALmV4
ZS5hJworICAgIG1vZF9saW5rX3dpdGhfbmFtZSA9ICdsaWJAMEAuYScKICAgZW5kaWYKICAg
bW9kX2xpbmtfYXJnc19mbXQgPSBbJ0AwQCddCiAgIG1vZF9saW5rX3dpdGhfZGlyID0gJ2xp
YmRpcicKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL21lc29uLmJ1aWxkIGIvc3JjL2JhY2tl
bmQvbWVzb24uYnVpbGQKaW5kZXggNDM2YzA0YWYwODAuLjc4YzU3MjY4MTQyIDEwMDY0NAot
LS0gYS9zcmMvYmFja2VuZC9tZXNvbi5idWlsZAorKysgYi9zcmMvYmFja2VuZC9tZXNvbi5i
dWlsZApAQCAtMTMzLDcgKzEzMyw3IEBAIHBvc3RncmVzID0gZXhlY3V0YWJsZSgncG9zdGdy
ZXMnLAogICBsaW5rX3dpdGg6IGJhY2tlbmRfbGlua193aXRoLAogICBsaW5rX2RlcGVuZHM6
IGJhY2tlbmRfbGlua19kZXBlbmRzLAogICBleHBvcnRfZHluYW1pYzogdHJ1ZSwKLSAgaW1w
bGliOiB0cnVlLAorICBpbXBsaWI6ICdwb3N0Z3JlcycsCiAgIGRlcGVuZGVuY2llczogYmFj
a2VuZF9idWlsZF9kZXBzLAogICBrd2FyZ3M6IGRlZmF1bHRfYmluX2FyZ3MsCiApCi0tIAoy
LjQ1LjIKCg==

--------------IFVrWVNxHn6A09fQ90PMHlPH--