Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ib1ZN-0003rf-8p for pgsql-bugs@arkaria.postgresql.org; Sat, 30 Nov 2019 12:09:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ib1ZM-000354-1Y for pgsql-bugs@arkaria.postgresql.org; Sat, 30 Nov 2019 12:09:48 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ib1ZL-00034x-Iq for pgsql-bugs@lists.postgresql.org; Sat, 30 Nov 2019 12:09:47 +0000 Received: from cyclops.postgrespro.ru ([93.174.131.138] helo=mail.postgrespro.ru) by makus.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ib1ZH-0004jR-64 for pgsql-bugs@postgresql.org; Sat, 30 Nov 2019 12:09:46 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.postgrespro.ru (Postfix) with ESMTP id C35F921C57FF for ; Sat, 30 Nov 2019 15:09:40 +0300 (MSK) X-Virus-Scanned: Debian amavisd-new at postgrespro.ru X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=x tagged_above=-99 required=4 WHITELISTED tests=[] autolearn=unavailable Received: from [192.168.3.134] (broadband-95-84-150-205.ip.moscow.rt.ru [95.84.150.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mail.postgrespro.ru (Postfix) with ESMTPSA id 7F23A21C57F5 for ; Sat, 30 Nov 2019 15:09:40 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1575115780; bh=LVRggycwzd1Ngip35HJU1Xc23bWiOBKA71MZRsvkAb0=; h=To:From:Subject:Date; b=qPi/Zz5zoCD2y1zKJ6QfrcMDu+gI7weVcLqliNEFnFY37cUSJCMq5Y76HeyUowsh0 pTThL+zyOlS4RbUGwxAWs83X1/NgQK5FuMLdtI5KWqVsBjWXckXdOxWhtazGlst1OB QAOu2nkITzruU2STAvkuvchXDb7T5RBg/EFkIBHo= To: Pg Bugs From: Grigory Smolkin Subject: logical replication: could not create file "state.tmp": File exists Message-ID: <08bbfab1-a61d-3750-fc18-4ab2c1aa7f09@postgrespro.ru> Date: Sat, 30 Nov 2019 15:09:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------0CD2B2B8C60D185A86E08E68" Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is a multi-part message in MIME format. --------------0CD2B2B8C60D185A86E08E68 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Hello! One of my colleagues encountered an out of space condition, which broke his logical replication setup. It`s manifested with the following errors: ERROR:  could not receive data from WAL stream: ERROR:  could not create file "pg_replslot/some_sub/state.tmp": File exists I`ve digged a bit into this problem, and it`s turned out that in SaveSlotToPath() temp file for replication slot is opened with 'O_CREAT | O_EXCL' flags, which makes this routine as not very reentrant. Since an exclusive lock is taken before temp file creation, I think it should be safe to replace O_EXCL with O_TRUNC. Script to reproduce and patch are attached. -- Grigory Smolkin Postgres Professional: http://www.postgrespro.com The Russian Postgres Company --------------0CD2B2B8C60D185A86E08E68 Content-Type: application/x-shellscript; name="replication_bug.sh" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="replication_bug.sh" IyEvYmluL2Jhc2gKCnNldCAtZXh1CnNldCAtbyBlcnJleGl0CgpQUkVGSVg9L2hvbWUvZ3Nt b2wvdGFzay8xM19kZXZlbApQR0RBVEFfUFVCPSR7UFJFRklYfS9kYXRhX3B1YgpQR0RBVEFf U1VCPSR7UFJFRklYfS9kYXRhX3N1YgpQT1JUX1BVQj0xNTQzMQpQT1JUX1NVQj0xNTQzMAoK JHtQUkVGSVh9L2Jpbi9wZ19jdGwgc3RvcCAtbSBpbW1lZGlhdGUgLUQgJHtQR0RBVEFfUFVC fSB8fCBlY2hvICJhbGwgaXMgd2VsbCIKJHtQUkVGSVh9L2Jpbi9wZ19jdGwgc3RvcCAtbSBp bW1lZGlhdGUgLUQgJHtQR0RBVEFfU1VCfSB8fCBlY2hvICJhbGwgaXMgd2VsbCIKcm0gLXJm ICR7UEdEQVRBX1BVQn0gJHtQR0RBVEFfU1VCfQoKJHtQUkVGSVh9L2Jpbi9pbml0ZGIgLWsg LUQgJHtQR0RBVEFfUFVCfQplY2hvICJwb3J0ID0gJHtQT1JUX1BVQn0iID4+ICR7UEdEQVRB X1BVQn0vcG9zdGdyZXNxbC5hdXRvLmNvbmYKZWNobyAid2FsX2xldmVsID0gbG9naWNhbCIg Pj4gJHtQR0RBVEFfUFVCfS9wb3N0Z3Jlc3FsLmF1dG8uY29uZgoKJHtQUkVGSVh9L2Jpbi9p bml0ZGIgLWsgLUQgJHtQR0RBVEFfU1VCfQplY2hvICJwb3J0ID0gJHtQT1JUX1NVQn0iID4+ ICR7UEdEQVRBX1NVQn0vcG9zdGdyZXNxbC5hdXRvLmNvbmYKCiMgc3RhcnQgcHVibGlzaGVy IGNsdXN0ZXIKJHtQUkVGSVh9L2Jpbi9wZ19jdGwgc3RhcnQgLUQgJHtQR0RBVEFfUFVCfQoK IyBzdGFydCBzdWJzY3JpYmVyIGNsdXN0ZXIKJHtQUkVGSVh9L2Jpbi9wZ19jdGwgc3RhcnQg LUQgJHtQR0RBVEFfU1VCfQoKIyBnZW5lcmF0ZSBzb21lIGRhdGEKJHtQUkVGSVh9L2Jpbi9w Z2JlbmNoIC1pIC1zIDEwIC1wICR7UE9SVF9QVUJ9IHBvc3RncmVzCgojIFBVQkxJQ0FUSU9O CiR7UFJFRklYfS9iaW4vcHNxbCAtcCAke1BPUlRfUFVCfSAtZCBwb3N0Z3JlcyAtYyAiQ1JF QVRFIFBVQkxJQ0FUSU9OIG15cHViIEZPUiB0YWJsZSBwZ2JlbmNoX2FjY291bnRzIgoKIyBT VUJTQ1JJUFRJT04KJHtQUkVGSVh9L2Jpbi9wc3FsIC1wICR7UE9SVF9TVUJ9IC1kIHBvc3Rn cmVzIC1jICJDUkVBVEUgVEFCTEUgcGdiZW5jaF9hY2NvdW50cyhhaWQgaW50IG5vdCBudWxs IFBSSU1BUlkgS0VZLCBiaWQgaW50LGFiYWxhbmNlIGludCxmaWxsZXIgY2hhcig4NCkpIgok e1BSRUZJWH0vYmluL3BzcWwgLXAgJHtQT1JUX1NVQn0gLWQgcG9zdGdyZXMgLWMgIkNSRUFU RSBTVUJTQ1JJUFRJT04gbXlzdWIgQ09OTkVDVElPTiAnaG9zdD1sb2NhbGhvc3QgcG9ydD0k e1BPUlRfUFVCfSBkYm5hbWU9cG9zdGdyZXMnIFBVQkxJQ0FUSU9OIG15cHViIgoKIyBJbWl0 YXRlIG91dF9vZl9zcGFjZS93cml0ZV9vcGVyYXRpb25fZXJyb3IKdG91Y2ggJHtQR0RBVEFf UFVCfS9wZ19yZXBsc2xvdC9teXN1Yi9zdGF0ZS50bXAKCiMgZ2VuZXJhdGUgc29tZSB3cml0 ZSBsb2FkCiR7UFJFRklYfS9iaW4vcGdiZW5jaCAtVDEwMCAtUDEgLXAgJHtQT1JUX1BVQn0g cG9zdGdyZXMK --------------0CD2B2B8C60D185A86E08E68 Content-Type: text/x-patch; name="0001-logical_replication_fix.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-logical_replication_fix.patch" diff --git a/src/backend/replication/slot.c b/src/backend/replication/slot.c index 21ae8531b3..ef415b44c8 100644 --- a/src/backend/replication/slot.c +++ b/src/backend/replication/slot.c @@ -1253,7 +1253,7 @@ SaveSlotToPath(ReplicationSlot *slot, const char *dir, int elevel) sprintf(tmppath, "%s/state.tmp", dir); sprintf(path, "%s/state", dir); - fd = OpenTransientFile(tmppath, O_CREAT | O_EXCL | O_WRONLY | PG_BINARY); + fd = OpenTransientFile(tmppath, O_CREAT | O_TRUNC | O_WRONLY | PG_BINARY); if (fd < 0) { ereport(elevel, --------------0CD2B2B8C60D185A86E08E68--