MIME-Version: 1.0
Date: Tue, 19 Sep 2023 11:15:29 +0300
From: Alexander Pyhalov <a.pyhalov@postgrespro.ru>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Alexander Lakhin <exclusion@gmail.com>, Masahiko Sawada
 <sawada.mshk@gmail.com>, bowenshi <zxwsbg@qq.com>,
 pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17695: Failed Assert in logical replication snapbuild.
In-Reply-To: <9C8BF118-5869-49B0-81D7-BA072AD8E88E@yesql.se>
References: <17695-6be9277c9295985f@postgresql.org>
 <CAD21AoCsxvV3Mpzv8Q3hG7CdQZ7vSBWyEFLgY3QZARRDcgzVwA@mail.gmail.com>
 <tencent_7EB71DA5D7BA00EB0B429DCE45D0452B6406@qq.com>
 <CAD21AoAofY33TOdvJ_FHAob8C+H4gKOrnK_V+p3XzEMPQO24Cg@mail.gmail.com>
 <DB7F9F38-11F6-4EA2-B414-5BD925A1FE25@yesql.se>
 <CAD21AoDNv09ZMr-E+fNzhduvkE6eK2fjCRA7wJHOhF8APH5JdQ@mail.gmail.com>
 <7e4d4a80-3e3c-231f-f886-6cada2aa582b@gmail.com>
 <CAD21AoDyE91TroZQOtSyjq-k9KmUOHTfUe1mG7kFLDCLTHNH_A@mail.gmail.com>
 <102cb85d-2205-c8ec-ac37-797c03e025e1@gmail.com>
 <9C8BF118-5869-49B0-81D7-BA072AD8E88E@yesql.se>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <09bebdfe9d4a2c6155379442f0771bfe@postgrespro.ru>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/09bebdfe9d4a2c6155379442f0771bfe%40postgrespro.ru>
Precedence: bulk

Daniel Gustafsson писал 2023-07-04 18:43:
>> On 23 May 2023, at 13:00, Alexander Lakhin <exclusion@gmail.com> 
>> wrote:
>> 
>> 22.05.2023 03:56, Masahiko Sawada wrote:
>>> On Thu, May 18, 2023 at 11:00 PM Alexander Lakhin 
>>> <exclusion@gmail.com> wrote:
>>> 
>>>> I can easily (without gdb and sleep()) reproduce the issue on master 
>>>> with
>>>> the following script:
>>>> ...
>>> Thank you for sharing the script. But it seems not stable as I could
>>> not reproduce the issue in my environment. I think we need a stable
>>> reproducer so that we can include it in core regression tests. Or it
>>> may be okay not to include it if we could not find a convenient way
>>> and the fix is trivial.
>> 
>> I've came to the minimal reproducer:
> 
> Thanks for the reproducer, I was able to reproduce this in HEAD and 
> v16.
> 
>> It's hardly suitable for the regression test, but it clearly 
>> demonstrates the
>> issue without using gdb. With the fix from [1] applied, I've got no 
>> failures,
>> even with numclients=100, for 10 runs.
>> 
>> I also think, that the fix is simple enough to be committed without a
>> complicated/resource-intensive regression test.
> 
> I'm not convinced we need a regression test for this as it would be 
> very
> expensive and potentially brittle for older/slower buildfarm members 
> while
> giving few gains.
> 
> I've applied this to HEAD and backpatched it to v16.
> 

Hi.
It seems we've managed to get this issue on 14.8. Is there any reason 
why it wasn't applied to earlier versions?
-- 
Best regards,
Alexander Pyhalov,
Postgres Professional