Subject: Re: BUG #15910: Valgrind-detected error in DecodeTimeOnly
To: pgsql-bugs@lists.postgresql.org
References: <15910-2eba5106b9aa0c61@postgresql.org>
From: Alexander Lakhin <exclusion@gmail.com>
Message-ID: <0aaf1cb9-0f85-e786-fb32-b3d68b80d027@gmail.com>
Date: Tue, 16 Jul 2019 19:24:56 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <15910-2eba5106b9aa0c61@postgresql.org>
Content-Type: multipart/mixed;
 boundary="------------85EDEB98F6040A61207ECA35"
Content-Language: ru-RU
Precedence: bulk

This is a multi-part message in MIME format.
--------------85EDEB98F6040A61207ECA35
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

> Bug reference:      15910
> Logged by:          Alexander Lakhin
> Email address:      exclusion@gmail.com
> PostgreSQL version: 12beta2
> Operating system:   Ubuntu 18.04
> Description:        
>
> When executing the following query:
> SELECT time with time zone '04:05:06 m2';
> I get a strange result:
>       timetz
> -------------------
>  04:05:06+02:30:17
> and the valgrind errors:
> ==00:00:00:07.177 31724== Conditional jump or move depends on uninitialised
> value(s)
> ==00:00:00:07.177 31724==    at 0x57333D: DetermineTimeZoneOffsetInternal
> (datetime.c:1485)
> ==00:00:00:07.177 31724==    by 0x573DA6: DetermineTimeZoneOffset
The attached patch fixes this issue.

Best regards,
Alexander

--------------85EDEB98F6040A61207ECA35
Content-Type: text/x-patch;
 name="fix-DecodeTimeOnly.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="fix-DecodeTimeOnly.patch"

diff --git a/src/backend/utils/adt/datetime.c b/src/backend/utils/adt/datetime.c
index 54ea69f7f1..0a13ec8492 100644
--- a/src/backend/utils/adt/datetime.c
+++ b/src/backend/utils/adt/datetime.c
@@ -2280,6 +2280,9 @@ DecodeTimeOnly(char **field, int *ftype, int nf,
 			GetCurrentDateTime(tmp);
 		else
 		{
+			/* a date has to be fully specified */
+			if ((fmask & DTK_DATE_M) != DTK_DATE_M)
+				return DTERR_BAD_FORMAT;
 			tmp->tm_year = tm->tm_year;
 			tmp->tm_mon = tm->tm_mon;
 			tmp->tm_mday = tm->tm_mday;
@@ -2307,6 +2310,9 @@ DecodeTimeOnly(char **field, int *ftype, int nf,
 			GetCurrentDateTime(tmp);
 		else
 		{
+			/* a date has to be fully specified */
+			if ((fmask & DTK_DATE_M) != DTK_DATE_M)
+				return DTERR_BAD_FORMAT;
 			tmp->tm_year = tm->tm_year;
 			tmp->tm_mon = tm->tm_mon;
 			tmp->tm_mday = tm->tm_mday;

--------------85EDEB98F6040A61207ECA35--