MIME-Version: 1.0
Date: Thu, 03 Feb 2022 13:37:55 +0300
From: Marina Polyakova <m.polyakova@postgrespro.ru>
To: Etsuro Fujita <etsuro.fujita@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Alexander Lakhin
 <exclusion@gmail.com>, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17355: Server crashes on ExecReScanForeignScan in
 postgres_fdw when accessing foreign partition
In-Reply-To: 
 <CAPmGK15oOhQGwp2z1+a+PTcz93Rbvq7Q8wtaXTOM6WZp2wbpLA@mail.gmail.com>
References: 
 <CAPmGK166WGTskmduTR+N7enYDUGrtvmVLZPn0ak_gk3gcYTaCQ@mail.gmail.com>
 <202202021442.hsxbhre2k533@alvherre.pgsql>
 <CAPmGK15oOhQGwp2z1+a+PTcz93Rbvq7Q8wtaXTOM6WZp2wbpLA@mail.gmail.com>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <0c5d710abcd92dc474b04ce802055a9f@postgrespro.ru>
Organization: Postgres Professional
Content-Type: multipart/mixed;
 boundary="=_fc40521d129ac586c0f3737e947229c5"
Archived-At: 
 <https://www.postgresql.org/message-id/0c5d710abcd92dc474b04ce802055a9f%40postgrespro.ru>
Precedence: bulk

--=_fc40521d129ac586c0f3737e947229c5
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset=UTF-8;
 format=flowed

On 2022-02-03 09:38, Etsuro Fujita wrote:
> I think it would be better to create a separate patch so that we test
> not only this but other EvalPlanQual stuff such as ForeignRecheck, so
> I applied the proposed patch to HEAD as well.
> 
> Thanks!
> 
> Best regards,
> Etsuro Fujita

Hello everyone in this thread!

Looks like gcc 11.2.0 is now reporting a warning in the branches 
master/REL_14_STABLE, e.g. see CI 
https://github.com/postgres/postgres/runs/5047720839:

[06:30:18.201] nodeForeignscan.c: In function ‘ForeignNext’:
[06:30:18.201] nodeForeignscan.c:47:13: error: unused variable ‘estate’ 
[-Werror=unused-variable]
[06:30:18.201]    47 |  EState    *estate = node->ss.ps.state;
[06:30:18.201]       |             ^~~~~~

Please could you fix it? E.g. like in the attached patch - the following 
commands work for me with it:

$ ./configure && COPT=-Werror make world-bin

-- 
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
--=_fc40521d129ac586c0f3737e947229c5
Content-Transfer-Encoding: base64
Content-Type: text/x-diff;
 name=diff_fix_ForeignNext_warning.patch
Content-Disposition: attachment;
 filename=diff_fix_ForeignNext_warning.patch;
 size=661

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2V4ZWN1dG9yL25vZGVGb3JlaWduc2Nhbi5jIGIvc3Jj
L2JhY2tlbmQvZXhlY3V0b3Ivbm9kZUZvcmVpZ25zY2FuLmMKaW5kZXggMmM4N2IyZTIzOGEwZGE3
NjZiMTAzNzI4ZTc5MTUzOWRiMzkzYWRiZi4uMGZmMjA2NDMzNWZmNWJkMjVmMTUzMTc5M2RlMzUw
MzEwZTk2OWJhMyAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvZXhlY3V0b3Ivbm9kZUZvcmVpZ25z
Y2FuLmMKKysrIGIvc3JjL2JhY2tlbmQvZXhlY3V0b3Ivbm9kZUZvcmVpZ25zY2FuLmMKQEAgLTQ0
LDcgKzQ0LDcgQEAgRm9yZWlnbk5leHQoRm9yZWlnblNjYW5TdGF0ZSAqbm9kZSkKIAlUdXBsZVRh
YmxlU2xvdCAqc2xvdDsKIAlGb3JlaWduU2NhbiAqcGxhbiA9IChGb3JlaWduU2NhbiAqKSBub2Rl
LT5zcy5wcy5wbGFuOwogCUV4cHJDb250ZXh0ICplY29udGV4dCA9IG5vZGUtPnNzLnBzLnBzX0V4
cHJDb250ZXh0OwotCUVTdGF0ZQkgICAqZXN0YXRlID0gbm9kZS0+c3MucHMuc3RhdGU7CisJRVN0
YXRlCSAgICplc3RhdGUgUEdfVVNFRF9GT1JfQVNTRVJUU19PTkxZID0gbm9kZS0+c3MucHMuc3Rh
dGU7CiAJTWVtb3J5Q29udGV4dCBvbGRjb250ZXh0OwogCiAJLyogQ2FsbCB0aGUgSXRlcmF0ZSBm
dW5jdGlvbiBpbiBzaG9ydC1saXZlZCBjb250ZXh0ICovCg==
--=_fc40521d129ac586c0f3737e947229c5--