From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
cc: Greg Hennessy <greg.hennessy@gmail.com>, pgsql-bugs@lists.postgresql.org,
        =?UTF-8?B?RGV2cmltIEfDvG5kw7x6?= <devrim@gunduz.org>
Subject: Re: missing requirement on ccache in postgresql16-devel
In-reply-to: <ZTlGvDyjfjPbnolk@momjian.us>
References: 
 <CA+mZaON9nDxWrg=ABBczU3DuYwQ3Q02atsY+Xhb0ogAgHzmYVg@mail.gmail.com>
 <ZTlGvDyjfjPbnolk@momjian.us>
Comments: In-reply-to Bruce Momjian <bruce@momjian.us>
	message dated "Wed, 25 Oct 2023 12:47:56 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1000998.1698254504.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 25 Oct 2023 13:21:44 -0400
Message-ID: <1000999.1698254504@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1000999.1698254504%40sss.pgh.pa.us>
Precedence: bulk

Bruce Momjian <bruce@momjian.us> writes:
> On Wed, Oct 25, 2023 at 11:25:15AM -0400, Greg Hennessy wrote:
>> The file /usr/pgsql-16/lib/pgxs/src/Makefile.global has a reference
>> to ccache but the rpm doesn't list this as a dependency. I would like
>> to submit that it is a bug that it does not.

> Uh, ccache is an _optional_ way to speed up compilation.  It is not a
> requirement/dependency.

Yeah, but if the Makefile says "CC =3D ccache gcc" then anybody
trying to build under PGXS will fail if they don't have ccache
installed.  So I think Greg has a point.

On typical Red Hat setups, it's not necessary to mention ccache
explicitly to use it; instead that's managed via PATH.  For
example, I have

$ which gcc
/usr/lib64/ccache/gcc

$ ls -l /usr/lib64/ccache/gcc
lrwxrwxrwx. 1 root root 16 May 21 09:35 /usr/lib64/ccache/gcc -> ../../bin=
/ccache

so it Just Works.  I'd suggest arranging the rpm builds to be
done similarly, and then you get ccache usage in the rpm build,
while the distributed Makefile will just say "CC =3D gcc" so
it will work for users whether they use ccache or not.

			regards, tom lane