From: Tom Lane <tgl@sss.pgh.pa.us>
To: John Naylor <john.naylor@enterprisedb.com>
cc: kjs@teews.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17128: minimum numeric 'integer' is -2147483647 not
 -2147483648 as documented
In-reply-to: 
 <CAFBsxsEf6qMvYf5WbDOUdr57mGq18La21R4wNr5=zm4C-1vs6A@mail.gmail.com>
References: <17128-55a8a879727a3e3a@postgresql.org>
 <CAFBsxsEf6qMvYf5WbDOUdr57mGq18La21R4wNr5=zm4C-1vs6A@mail.gmail.com>
Comments: In-reply-to John Naylor <john.naylor@enterprisedb.com>
	message dated "Fri, 30 Jul 2021 11:05:14 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1003601.1627658072.1@sss.pgh.pa.us>
Date: Fri, 30 Jul 2021 11:14:32 -0400
Message-ID: <1003602.1627658072@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1003602.1627658072%40sss.pgh.pa.us>
Precedence: bulk

John Naylor <john.naylor@enterprisedb.com> writes:
> On Fri, Jul 30, 2021 at 7:53 AM PG Bug reporting form <
> noreply@postgresql.org> wrote:
>> -   if (l < -INT_MAX || l > INT_MAX)
>> +   if (l < (-INT_MAX - 1) || l > INT_MAX)

> Yeah, that looks like it should be INT_MIN instead. I'll see about making
> that happen. Thanks for the report!

The whole stanza perhaps ought to be within

#if SIZEOF_LONG > SIZEOF_INT

otherwise some compilers will bleat about useless tests.

(I looked at PGTYPESnumeric_to_long and it seems like it will do
the right thing for 32-bit long, assuming strtol does.)

			regards, tom lane