Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pGj6E-0000zL-25 for pgsql-bugs@arkaria.postgresql.org; Sat, 14 Jan 2023 16:09:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pGj6C-0006Lw-MR for pgsql-bugs@arkaria.postgresql.org; Sat, 14 Jan 2023 16:09:40 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pGj6C-0006Lk-EV for pgsql-bugs@lists.postgresql.org; Sat, 14 Jan 2023 16:09:40 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pGj6A-0001oJ-B3 for pgsql-bugs@lists.postgresql.org; Sat, 14 Jan 2023 16:09:39 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 30EG9bfx1006697; Sat, 14 Jan 2023 11:09:37 -0500 From: Tom Lane To: Sam S cc: pgsql-bugs@lists.postgresql.org Subject: Re: BUG #17739: postgres ts_headline function is not returning matches it should during full text search In-reply-to: References: <17739-2f20af14b5644ef9@postgresql.org> <4109476.1673278808@sss.pgh.pa.us> Comments: In-reply-to Sam S message dated "Fri, 13 Jan 2023 21:23:18 -0500" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1006695.1673712577.1@sss.pgh.pa.us> Date: Sat, 14 Jan 2023 11:09:37 -0500 Message-ID: <1006696.1673712577@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Sam S writes: > I applied that patch to the main branch, built and tested it and it works > as I expect. > I reviewed the code and it looks good to me as far as someone not familiar > with the codebase can tell. Thanks for testing! "Does it work as you expect" is exactly the thing I'm most concerned about here, so your input is very valuable. regards, tom lane