From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
cc: David Rowley <dgrowleyml@gmail.com>, usamoi@outlook.com,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18637: CREATE INDEX won't look up operator classes in
 search_path if PARTITION BY is specified
In-reply-to: <20241004023337.36.nmisch@google.com>
References: <18637-f51e314546e3ba2a@postgresql.org>
 <CAApHDvrmBSTA8-Sv=HEQvrPO8QDPLB7y0d0gJweBQe2c8PMGYw@mail.gmail.com>
 <231375.1727925543@sss.pgh.pa.us> <364851.1727974294@sss.pgh.pa.us>
 <427540.1727979435@sss.pgh.pa.us> <20241004023337.36.nmisch@google.com>
Comments: In-reply-to Noah Misch <noah@leadboat.com>
	message dated "Thu, 03 Oct 2024 19:33:37 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1055979.1728154085.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sat, 05 Oct 2024 14:48:05 -0400
Message-ID: <1055980.1728154085@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1055980.1728154085%40sss.pgh.pa.us>
Precedence: bulk

Noah Misch <noah@leadboat.com> writes:
> On Thu, Oct 03, 2024 at 02:17:15PM -0400, Tom Lane wrote:
>> This could stand an additional regression test case perhaps,
>> but the core tests don't have a suitable opclass at hand.
>> Maybe we could test it in some contrib module, but that
>> seems a shade hacky.

> For contrib/citext/sql/create_index_acl.sql, I settled on testing in con=
trib.
> I valued the test fidelity of a real opclass more than I disliked the us=
e of
> contrib.  The distinction between the various parts of check-world is bl=
urry
> to non-hackers, so I expect it won't bother them.

Agreed.  Pushed it with a test added to contrib/seg, just to be
different.

			regards, tom lane