Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iZNco-0001TK-PU for pgsql-bugs@arkaria.postgresql.org; Mon, 25 Nov 2019 23:18:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iZNcm-0002LS-9N for pgsql-bugs@arkaria.postgresql.org; Mon, 25 Nov 2019 23:18:32 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iZNcm-0002Jn-0S for pgsql-bugs@lists.postgresql.org; Mon, 25 Nov 2019 23:18:32 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iZNcj-0007yf-61 for pgsql-bugs@lists.postgresql.org; Mon, 25 Nov 2019 23:18:31 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id xAPNIPt1010566; Mon, 25 Nov 2019 18:18:25 -0500 From: Tom Lane To: exclusion@gmail.com cc: pgsql-bugs@lists.postgresql.org Subject: Re: BUG #16137: pg_upgrade fails with an index over nesting function In-reply-to: <16137-4917a81e8491110e@postgresql.org> References: <16137-4917a81e8491110e@postgresql.org> Comments: In-reply-to PG Bug reporting form message dated "Mon, 25 Nov 2019 21:00:07 +0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <10564.1574723905.1@sss.pgh.pa.us> Date: Mon, 25 Nov 2019 18:18:25 -0500 Message-ID: <10565.1574723905@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk PG Bug reporting form writes: > CREATE TABLE test(i INT PRIMARY KEY); > CREATE FUNCTION func2(i INT) RETURNS INT IMMUTABLE LANGUAGE SQL > AS 'SELECT $1'; > CREATE FUNCTION func1(c INT) RETURNS INT IMMUTABLE LANGUAGE SQL > AS 'SELECT func2($1)'; This function is unreliable for lack of schema qualification. I tend to agree that it'd be nice if pg_upgrade wouldn't be so picky about that, but we haven't really found a way that doesn't create security issues (cf CVE-2018-1058). regards, tom lane