Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1pVhoa-0005VB-VT
	for pgsql-bugs@arkaria.postgresql.org; Fri, 24 Feb 2023 23:49:24 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1pVhoZ-0003c8-Bb
	for pgsql-bugs@arkaria.postgresql.org; Fri, 24 Feb 2023 23:49:23 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1pVhoY-0003bw-W0
	for pgsql-bugs@lists.postgresql.org; Fri, 24 Feb 2023 23:49:22 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1pVhoS-0007m6-2i
	for pgsql-bugs@lists.postgresql.org; Fri, 24 Feb 2023 23:49:21 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 31ONnAEd1073423;
	Fri, 24 Feb 2023 18:49:10 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Michael Paquier <michael@paquier.xyz>, exclusion@gmail.com,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17800: ON CONFLICT DO UPDATE fails to detect incompatible
 fields that leads to a server crash
In-reply-to: <20230224225357.2orpiokrfpjllfm4@awork3.anarazel.de>
References: <20230222192350.wviaslfpo3w2ja3l@awork3.anarazel.de>
 <290812.1677101054@sss.pgh.pa.us> <586533.1677178414@sss.pgh.pa.us>
 <20230223210012.4qigvo6sryn2syu5@awork3.anarazel.de>
 <718944.1677189963@sss.pgh.pa.us>
 <20230223233636.zkt4tqzsc4b6ekwn@awork3.anarazel.de>
 <20230224015417.75yimxbksejpffh3@awork3.anarazel.de>
 <851179.1677259566@sss.pgh.pa.us>
 <20230224174412.xk3y364t6a2udp5t@awork3.anarazel.de>
 <1060251.1677276763@sss.pgh.pa.us>
 <20230224225357.2orpiokrfpjllfm4@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Fri, 24 Feb 2023 14:53:57 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1073421.1677282550.1@sss.pgh.pa.us>
Date: Fri, 24 Feb 2023 18:49:10 -0500
Message-ID: <1073422.1677282550@sss.pgh.pa.us>
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Archived-At: 
 <https://www.postgresql.org/message-id/1073422.1677282550%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2023-02-24 17:12:43 -0500, Tom Lane wrote:
>> I did the renaming you had comments suggesting, but perhaps you want
>> to bikeshed those names?

> Not really. I guess it'd be mildly nicer to have Expr somewhere in the name,
> but whatever.

Maybe Exec{Create|Push}ExprSetupSteps?

> The "don't bother" comment looks a bit lonely now :)

I figured it was important to leave a note that that was intentional.
Doesn't have to look exactly like that, though.

			regards, tom lane