Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1qvqA7-007nhv-V2
	for pgsql-bugs@arkaria.postgresql.org; Thu, 26 Oct 2023 02:31:55 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1qvqA5-00BUf4-F5
	for pgsql-bugs@arkaria.postgresql.org; Thu, 26 Oct 2023 02:31:53 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1qvqA5-00BUev-1u
	for pgsql-bugs@lists.postgresql.org; Thu, 26 Oct 2023 02:31:53 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by makus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1qvqA2-002Ktu-LV
	for pgsql-bugs@lists.postgresql.org; Thu, 26 Oct 2023 02:31:51 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 39Q2VnHp1074322;
	Wed, 25 Oct 2023 22:31:49 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Langote <amitlangote09@gmail.com>
cc: Hans Buschmann <buschmann@nidsa.net>, Peter Geoghegan <pg@bowt.ie>,
        "David G. Johnston" <david.g.johnston@gmail.com>,
        "pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>
Subject: Re: AW: AW: BUG #18147: ERROR: invalid perminfoindex 0 in RTE with
 relid xxxxx
In-reply-to: 
 <CA+HiwqFP1sjz1q678DetPftZoSw6ECO9mjiSOdAt290xSPSc8Q@mail.gmail.com>
References: <18147-6fc796538913ee88@postgresql.org>
 <CAKFQuwYFq-Q2rxbXXBmdHCAEFm-Pu_qhPAEi-PO+LmjtYN2hhg@mail.gmail.com>
 <2796464.1696525626@sss.pgh.pa.us>
 <9fdfed847859435e8641e613198be9e3@nidsa.net>
 <3319880.1696778678@sss.pgh.pa.us>
 <3c9fe737f6aa4ae9b0dc19bffd97e106@nidsa.net>
 <408285.1698085850@sss.pgh.pa.us> <428393.1698094765@sss.pgh.pa.us>
 <CA+HiwqHEdX7SSTLJw0=F3nU_BRyn2tUsw7A-cQs+=M_RL0czSw@mail.gmail.com>
 <556852.1698158932@sss.pgh.pa.us> <839708.1698174464@sss.pgh.pa.us>
 <CA+HiwqFmOaOWXW=KNFGfHRaXME50SqZa__GvsWjaWVXSFyY0kw@mail.gmail.com>
 <967241.1698241891@sss.pgh.pa.us>
 <CA+HiwqFP1sjz1q678DetPftZoSw6ECO9mjiSOdAt290xSPSc8Q@mail.gmail.com>
Comments: In-reply-to Amit Langote <amitlangote09@gmail.com>
	message dated "Thu, 26 Oct 2023 11:27:00 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <1074320.1698287509.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Wed, 25 Oct 2023 22:31:49 -0400
Message-ID: <1074321.1698287509@sss.pgh.pa.us>
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Archived-At: 
 <https://www.postgresql.org/message-id/1074321.1698287509%40sss.pgh.pa.us>
Precedence: bulk

Amit Langote <amitlangote09@gmail.com> writes:
> On Wed, Oct 25, 2023 at 10:51 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Diff looks fine, but I'm not sure that it's appropriate to characterize
>> the existing code as an oversight.  It was a necessary hack while the
>> executor was behaving as it did (ie, using the first child as root).

> Ah, you're right.  I've updated the commit message.  Will push later today.

I'd suggest specifying *first* child RTE in the commit message.
LGTM otherwise.

			regards, tom lane