From: Tom Lane <tgl@sss.pgh.pa.us>
To: dan-eli@mail.ru
cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18797: pointer te->defn not checked for NULL
In-reply-to: <18797-e48e5e7be4954d72@postgresql.org>
References: <18797-e48e5e7be4954d72@postgresql.org>
Comments: In-reply-to PG Bug reporting form <noreply@postgresql.org>
	message dated "Thu, 06 Feb 2025 11:28:22 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1085621.1738855055.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 06 Feb 2025 10:17:35 -0500
Message-ID: <1085622.1738855055@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1085622.1738855055%40sss.pgh.pa.us>
Precedence: bulk

PG Bug reporting form <noreply@postgresql.org> writes:
> in function PGTYPEStimestamp_defmt_scan there is a usage of pgtypes_allo=
c().
> In other functions the result of pgtypes_alloc is being checked for NULL=
.

Thanks for the report!  It looks like this was already dealt with
during the v17 cycle:


Author: Michael Paquier <michael@paquier.xyz>
Branch: master Release: REL_17_BR [0a9118ccc] 2024-02-19 09:05:51 +0900

    ecpg: Fix error handling on OOMs when parsing timestamps
    =

    pgtypes_alloc() can return NULL when failing an allocation, which is
    something that PGTYPEStimestamp_defmt_asc() has forgotten about when
    translating a timestamp for 'D', 'r', 'R' and 'T' as these require a
    temporary allocation.
    =

    This is unlikely going to be a problem in practice, so no backpatch is
    done.
    =

    Author: Oleg Tselebrovskiy
    Discussion: https://postgr.es/m/bf47888585149f83b276861a1662f7e4@postg=
respro.ru


I tend to agree with Michael's conclusion that an error here is
improbable enough to not justify a back-patch.

			regards, tom lane