Message-ID: <10e94fed-70ab-4269-8145-41d05e55fa10@oss.nttdata.com>
Date: Thu, 9 Jan 2025 21:11:25 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: BUG #18663: synchronous_standby_names vs synchronous_commit vs
 pg_stat_replication
Content-Language: en-US
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: asphator@gmail.com, pgsql-bugs@lists.postgresql.org
References: <18663-b02f75cb919f1b60@postgresql.org>
 <a8794ab2-7fba-4541-98fa-528b1e03852c@oss.nttdata.com>
 <614200e4-9434-4aad-b44d-078bc6d5e65a@oss.nttdata.com>
In-Reply-To: <614200e4-9434-4aad-b44d-078bc6d5e65a@oss.nttdata.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/10e94fed-70ab-4269-8145-41d05e55fa10%40oss.nttdata.com>
Precedence: bulk


On 2025/01/09 9:35, Fujii Masao wrote:
> 
> 
> On 2024/10/21 18:43, Fujii Masao wrote:
>>
>>
>> On 2024/10/18 23:48, PG Bug reporting form wrote:
>>> The following bug has been logged on the website:
>>>
>>> Bug reference:      18663
>>> Logged by:          Asphator
>>> Email address:      asphator@gmail.com
>>> PostgreSQL version: 15.7
>>> Operating system:   RHEL7+
>>> Description:
>>>
>>> Hello
>>>
>>> I would like to raise 2 issues:
>>> - documentation issue
>>> - pg_stat_replication view issue in a very specific use case
>>>
>>> 1. Documentation
>>> Regarding parameter synchronous_standby_names, I did not manage to find
>>> anything in documentation preventing from setting value 0. The only thing
>>> I've found is a comment in a commit of 2016. Would be nice to mention in
>>> documentation that value must be a "positive" integer.
>>
>> Agreed. I've attached the patch.
> 
> I made a slight wording adjustment.
> Unless there are objections, I'll commit the attached patch.

Pushed.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION