From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
cc: pgsql-hackers@lists.postgresql.org, steven.winfield@cantabcapital.com
Subject: Re: BUG #16059: Tab-completion of filenames in COPY commands removes
 required quotes
In-reply-to: <d746fc4c-c47d-2581-e9b2-641b05e350e5@2ndquadrant.com>
References: <16059-8836946734c02b84@postgresql.org>
 <30313.1572729260@sss.pgh.pa.us> <1628.1572820800@sss.pgh.pa.us>
 <6ccd23e4-ce58-c2b5-39a1-801a9937ae86@2ndquadrant.com>
 <12699.1578058657@sss.pgh.pa.us> <32307.1578290788@sss.pgh.pa.us>
 <1ed54e8f-d84e-bfbe-ffad-890015e12735@2ndquadrant.com>
 <28497.1578947794@sss.pgh.pa.us> <22096.1578965897@sss.pgh.pa.us>
 <d746fc4c-c47d-2581-e9b2-641b05e350e5@2ndquadrant.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
	message dated "Thu, 23 Jan 2020 14:46:08 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <10999.1579795776.1@sss.pgh.pa.us>
Date: Thu, 23 Jan 2020 11:09:36 -0500
Message-ID: <11000.1579795776@sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 2020-01-14 02:38, Tom Lane wrote:
>> On reflection, it seems like the best bet for the moment is to
>> remove double-quote from the rl_completer_quote_characters string,
>> which should restore all behavior around double-quoted strings to
>> what it was before.  (We have to keep single-quote in that string,
>> though, or quoted file names fail entirely.)

> This patch (version 6) looks good to me.

Thanks for reviewing!  Pushed, now we'll see what the buildfarm thinks...

			regards, tom lane