From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@alvh.no-ip.org>,
        Virender Singla <virender.cse@gmail.com>,
        pgsql-bugs@lists.postgresql.org, Aniket Jha <aniketkumarj@gmail.com>
Subject: Re: Major Version Upgrade failure due to orphan roles entries in catalog
In-reply-to: <304751.1772045891@sss.pgh.pa.us>
References: <202502131716.7mgkcnrem2hn@alvherre.pgsql> <2939991.1740089974@sss.pgh.pa.us> <CA+TgmoauoiW4ydDhdrseg+DD4Kwha=+TSZp18BrJeHKx3o1Fdw@mail.gmail.com> <179448.1772033773@sss.pgh.pa.us> <CA+TgmoYFc1x11Y7AHxn6Jb0mvJ9-aPttmjqezj=YKnHmqVb-Wg@mail.gmail.com> <265501.1772038216@sss.pgh.pa.us> <CA+TgmobNKFc34nj+w6iX0zWJ1=mfYWqQS91PqsJrm4VD4o1yOw@mail.gmail.com> <296083.1772041154@sss.pgh.pa.us> <CA+TgmoYJ8Y1G1r9U7pRwnyw=8dmM0xygLguE+bdihkN8GwPuCQ@mail.gmail.com> <301798.1772044229@sss.pgh.pa.us> <CA+TgmobZRL02-R7k_i3ENYz8CmqCPUZv6cHY51BejqPy7OhFJw@mail.gmail.com> <304751.1772045891@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Wed, 25 Feb 2026 13:58:11 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1103271.1772227345.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 27 Feb 2026 16:22:25 -0500
Message-ID: <1103272.1772227345@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/1103272.1772227345%40sss.pgh.pa.us>
Precedence: bulk

I wrote:
> I'd be content to use those wordings (except I think our style
> guide wants detail to be punctuated like a sentence).  I'll wait
> a day or so to see if anyone has a better idea, though.

When I looked at the code more closely, I realized that it already
doesn't dump grantors when dumping from pre-v16.  I'm inclined to
think that is an overreaction to the possible unreliability of the
data (and from your comment upthread you might agree).  But given
the lack of complaints about it, let's leave that as-is for now.
The immediate problem is that the code is allowing a null grantor to
suppress the GRANT altogether, *even if it's not going to use the
grantor*.  Clearly that's silly.  But if we're not going to use
the grantor, let's skip trying to fetch it, which means we also
don't need the info-level variant of the message.

So I end with the attached draft patch.

			regards, tom lane

#text/x-diff; name=3D"v1-clean-up-dumpRoleMembership.patch" [v1-clean-up-d=
umpRoleMembership.patch] /home/tgl/pgsql/v1-clean-up-dumpRoleMembership.pa=
tch