Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tcn4U-002gwp-3s for pgsql-bugs@arkaria.postgresql.org; Tue, 28 Jan 2025 15:00:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tcn4T-001eQG-9v for pgsql-bugs@arkaria.postgresql.org; Tue, 28 Jan 2025 15:00:09 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tcn4T-001eQ8-2C for pgsql-bugs@lists.postgresql.org; Tue, 28 Jan 2025 15:00:09 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tcn4Q-001yUd-0r for pgsql-bugs@lists.postgresql.org; Tue, 28 Jan 2025 15:00:08 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 50SF05Vi1124700; Tue, 28 Jan 2025 10:00:05 -0500 From: Tom Lane To: dan-eli@mail.ru cc: pgsql-bugs@lists.postgresql.org Subject: Re: BUG #18787: pointer te->defn not checked for NULL In-reply-to: <18787-676496fef9742cab@postgresql.org> References: <18787-676496fef9742cab@postgresql.org> Comments: In-reply-to PG Bug reporting form message dated "Tue, 28 Jan 2025 14:32:06 +0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1124698.1738076405.1@sss.pgh.pa.us> Date: Tue, 28 Jan 2025 10:00:05 -0500 Message-ID: <1124699.1738076405@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk PG Bug reporting form writes: > Here is a patch fixing the issue. I think that NULL check is needed here In none of these three bug reports have you given an actual bug report --- that is, there is no reason to believe that these patches fix any reachable failure case. If you have examples showing that the cases are reachable, please provide those first, and then we can discuss suitable fixes. regards, tom lane