From: Tom Lane <tgl@sss.pgh.pa.us>
To: Vinod Sridharan <vsridh90@gmail.com>
cc: niek.brasa@hitachienergy.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18831: Particular queries using gin-indexes are not
 interruptible, resulting is resource usage concerns.
In-reply-to: 
 <CAFMdLD4Ks5b=CbBh1PjFSytm0zdNv9-ddyeE+opusAKCVph7=g@mail.gmail.com>
References: <18831-e845ac44ebc5dd36@postgresql.org>
 <474911.1741207802@sss.pgh.pa.us>
 <CAFMdLD7XzsXfi1+DpTqTgrD8XU0i2C99KuF=5VHLWjx4C1pkcg@mail.gmail.com>
 <1026035.1744415680@sss.pgh.pa.us>
 <CAFMdLD4SC1=NDOHL-LOAonb6aycv2D1MGbwdiT3M9=A7SfiXow@mail.gmail.com>
 <1098251.1744426831@sss.pgh.pa.us>
 <CAFMdLD4Ks5b=CbBh1PjFSytm0zdNv9-ddyeE+opusAKCVph7=g@mail.gmail.com>
Comments: In-reply-to Vinod Sridharan <vsridh90@gmail.com>
	message dated "Fri, 11 Apr 2025 20:30:43 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1126690.1744435987.1@sss.pgh.pa.us>
Date: Sat, 12 Apr 2025 01:33:07 -0400
Message-ID: <1126691.1744435987@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1126691.1744435987%40sss.pgh.pa.us>
Precedence: bulk

Vinod Sridharan <vsridh90@gmail.com> writes:
> Since this is also called in the regular consistent function, this
> would be adding work in the regular consistent path - where the caller
> happens to reset the array for every invocation currently.

Ah, so you're just worried about the extra work in that path?
But MAX_MAYBE_ENTRIES is only 4, so I can't believe it'd amount
to much.

I am wondering about a test case.  I'm not thrilled about building
a specialized opclass just to test this.  contrib/hstore and
contrib/intarray already have opclasses with no triconsistent
function, so they should (and do) exercise shimTriConsistentFn
already.  But their tests failed to expose this bug.  I spent
a bit of time trying to add an example that would show the bug
in one or the other of those, and failed so far.  Any ideas?

			regards, tom lane