Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1iKiPS-00062M-0Y
	for pgsql-bugs@arkaria.postgresql.org; Wed, 16 Oct 2019 12:28:10 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1iKiPQ-00046R-Mf
	for pgsql-bugs@arkaria.postgresql.org; Wed, 16 Oct 2019 12:28:08 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1iKiPQ-000468-Eb
	for pgsql-bugs@lists.postgresql.org; Wed, 16 Oct 2019 12:28:08 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1iKiPN-0000Je-Vb
	for pgsql-bugs@lists.postgresql.org; Wed, 16 Oct 2019 12:28:08 +0000
Received: from pro.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x9GCRvCZ024071;
	Wed, 16 Oct 2019 08:27:57 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
cc: Andres Freund <andres@anarazel.de>, buschmann@nidsa.net,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16045: vacuum_db crash and illegal memory alloc after
 pg_upgrade from PG11 to PG12
In-reply-to: <20191016113344.ihrjpztakfppgilp@development>
References: <30706.1570717152@sss.pgh.pa.us>
 <20191010163350.2rtcjtje6tkgilqi@development> <1542.1570738460@sss.pgh.pa.us>
 <20191010204022.6hiiubm2cueu3ghk@development>
 <20191013001032.lqrn4kqaovhrf77l@development>
 <17717.1570991208@sss.pgh.pa.us>
 <20191013203848.2eksimmpux3546wr@development>
 <27596.1571062600@sss.pgh.pa.us>
 <20191014163538.cqn6j4cl7s2mk2yz@development>
 <20191015001817.zei45apgpu5dzngr@development>
 <20191016113344.ihrjpztakfppgilp@development>
Comments: In-reply-to Tomas Vondra <tomas.vondra@2ndquadrant.com>
	message dated "Wed, 16 Oct 2019 13:33:44 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <11352.1571228877.1@sss.pgh.pa.us>
Date: Wed, 16 Oct 2019 14:27:57 +0200
Message-ID: <11353.1571228877@sss.pgh.pa.us>
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Precedence: bulk

Tomas Vondra <tomas.vondra@2ndquadrant.com> writes:
> I've just committed and pushed both fixes after some minor corrections.

Not quite right in 9.6 and before, according to crake.  Looks like
some issue with the CppAsString2'd constants?  Did we even have
CppAsString2 that far back?

			regards, tom lane