Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ksq4T-0000MT-O7 for pgsql-bugs@arkaria.postgresql.org; Fri, 25 Dec 2020 16:36:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ksq4Q-0004VQ-Hm for pgsql-bugs@arkaria.postgresql.org; Fri, 25 Dec 2020 16:36:02 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ksq4Q-0004VJ-B2 for pgsql-bugs@lists.postgresql.org; Fri, 25 Dec 2020 16:36:02 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ksq4M-0001fF-LF for pgsql-bugs@lists.postgresql.org; Fri, 25 Dec 2020 16:36:00 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 0BPGZuGA1159816; Fri, 25 Dec 2020 11:35:56 -0500 From: Tom Lane To: stalkerg@gmail.com cc: pgsql-bugs@lists.postgresql.org Subject: Re: BUG #16791: Compile error with new ICU 68.2 for 10.15 In-reply-to: <16791-f0b801625fc78400@postgresql.org> References: <16791-f0b801625fc78400@postgresql.org> Comments: In-reply-to PG Bug reporting form message dated "Fri, 25 Dec 2020 12:39:14 +0000" MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-ID: <1159814.1608914156.1@sss.pgh.pa.us> Content-Transfer-Encoding: 8bit Date: Fri, 25 Dec 2020 11:35:56 -0500 Message-ID: <1159815.1608914156@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk PG Bug reporting form writes: > Log: > ``` > pg_collation.c:47:1: error: conflicting types for ‘CollationCreate’ > 47 | CollationCreate(const char *collname, Oid collnamespace, > | ^~~~~~~~~~~~~~~ > In file included from pg_collation.c:25: > ../../../src/include/catalog/pg_collation_fn.h:17:12: note: previous > declaration of ‘CollationCreate’ was here > 17 | extern Oid CollationCreate(const char *collname, Oid > collnamespace, > | ^~~~~~~~~~~~~~~ Presumably this is caused by ICU forcibly including and thereby changing what "bool" is. Since we only started to use stdbool.h booleans in v11, that's not going to work in v10 or below. I'm afraid that the short answer is "we're not gonna fix that". As per the other thread you mentioned, it's possible that we could make it work by #undef'ing bool in the right places. But the effort involved and the likely fragility of the results seem discouraging. If you want to use a bleeding-edge ICU version, don't use a hoary Postgres version. regards, tom lane