Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iKjKI-00083B-FK for pgsql-bugs@arkaria.postgresql.org; Wed, 16 Oct 2019 13:26:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iKjKG-0004uL-WC for pgsql-bugs@arkaria.postgresql.org; Wed, 16 Oct 2019 13:26:52 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iKjKG-0004uA-O1 for pgsql-bugs@lists.postgresql.org; Wed, 16 Oct 2019 13:26:52 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iKjKE-0000pp-JM for pgsql-bugs@lists.postgresql.org; Wed, 16 Oct 2019 13:26:52 +0000 Received: from pro.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x9GDQhgH026812; Wed, 16 Oct 2019 09:26:43 -0400 From: Tom Lane To: Tomas Vondra cc: Andres Freund , buschmann@nidsa.net, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #16045: vacuum_db crash and illegal memory alloc after pg_upgrade from PG11 to PG12 In-reply-to: <11353.1571228877@sss.pgh.pa.us> References: <30706.1570717152@sss.pgh.pa.us> <20191010163350.2rtcjtje6tkgilqi@development> <1542.1570738460@sss.pgh.pa.us> <20191010204022.6hiiubm2cueu3ghk@development> <20191013001032.lqrn4kqaovhrf77l@development> <17717.1570991208@sss.pgh.pa.us> <20191013203848.2eksimmpux3546wr@development> <27596.1571062600@sss.pgh.pa.us> <20191014163538.cqn6j4cl7s2mk2yz@development> <20191015001817.zei45apgpu5dzngr@development> <20191016113344.ihrjpztakfppgilp@development> <11353.1571228877@sss.pgh.pa.us> Comments: In-reply-to Tom Lane message dated "Wed, 16 Oct 2019 14:27:57 +0200" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <11664.1571232402.1@sss.pgh.pa.us> Date: Wed, 16 Oct 2019 15:26:42 +0200 Message-ID: <11665.1571232402@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk I wrote: > Tomas Vondra writes: >> I've just committed and pushed both fixes after some minor corrections. > Not quite right in 9.6 and before, according to crake. Looks like > some issue with the CppAsString2'd constants? Did we even have > CppAsString2 that far back? Yeah, we did. On closer inspection I suspect that we need to #include some other file to get the RELKIND_ constants in the old branches. regards, tom lane