Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1t2JBb-002xES-Pq
	for pgsql-hackers@arkaria.postgresql.org; Sat, 19 Oct 2024 23:48:43 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1t2JBa-0099y6-2Z
	for pgsql-hackers@arkaria.postgresql.org; Sat, 19 Oct 2024 23:48:42 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1t2JBZ-0099xx-PK
	for pgsql-hackers@lists.postgresql.org; Sat, 19 Oct 2024 23:48:42 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1t2JBX-001yV6-QE
	for pgsql-hackers@lists.postgresql.org; Sat, 19 Oct 2024 23:48:41 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 49JNmZHo1184580;
	Sat, 19 Oct 2024 19:48:35 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
cc: Justin Pryzby <pryzby@telsasoft.com>, Robert Haas <robertmhaas@gmail.com>,
        =?utf-8?B?0JDQvdC00YDQtdC5INCg0LDRh9C40YbQutC40Lk=?=
 <therealgofman@mail.ru>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: BUG #18545: \dt breaks transaction,
 calling error when executed in SET SESSION AUTHORIZATION
In-reply-to: <20241019232815.c6.nmisch@google.com>
References: <72802.1721415837@sss.pgh.pa.us>
 <1722241488.182053205@f169.i.mail.ru> <3593204.1722466756@sss.pgh.pa.us>
 <3618203.1722473994@sss.pgh.pa.us> <916377.1722809337@sss.pgh.pa.us>
 <CA+TgmoZ8owNGNkHUsoSL3cEd8C+zbb8w7-Oje0HYvfBp+btDBA@mail.gmail.com>
 <1807627.1722970465@sss.pgh.pa.us> <ZuoU_8EbSTE14o1U@pryzbyj2023>
 <1912093.1726716624@sss.pgh.pa.us> <2042942.1726781733@sss.pgh.pa.us>
 <20241019232815.c6.nmisch@google.com>
Comments: In-reply-to Noah Misch <noah@leadboat.com>
	message dated "Sat, 19 Oct 2024 16:28:15 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1184578.1729381715.1@sss.pgh.pa.us>
Date: Sat, 19 Oct 2024 19:48:35 -0400
Message-ID: <1184579.1729381715@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/1184579.1729381715%40sss.pgh.pa.us>
Precedence: bulk

Noah Misch <noah@leadboat.com> writes:
> Thanks for debugging that.  RestorePendingSyncs() also changes what
> RelationInitPhysicalAddr() puts in the relcache entry, so it needs to stay
> with RestoreRelationMap().  I'm attaching the fix I have in mind.

Ah.  No objections here.

			regards, tom lane