Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1w9a3K-001Yge-19
	for pgsql-bugs@arkaria.postgresql.org;
	Mon, 06 Apr 2026 02:51:02 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.96)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1w9a3H-0068SK-2T
	for pgsql-bugs@arkaria.postgresql.org;
	Mon, 06 Apr 2026 02:51:00 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1w9a3H-0068SB-1f
	for pgsql-bugs@lists.postgresql.org;
	Mon, 06 Apr 2026 02:50:59 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by magus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.98.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1w9a3F-00000000pdw-1Fa2
	for pgsql-bugs@lists.postgresql.org;
	Mon, 06 Apr 2026 02:50:59 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 6362osjR1197034;
	Sun, 5 Apr 2026 22:50:54 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: John Naylor <johncnaylorls@gmail.com>
cc: rekgrpth@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19450: Where is checksum_block.inc.c after master install?
In-reply-to: <CANWCAZYh-54rBucrL=tJQ5-UzRBUihZfS9wYtz=qUbhmuYJyxQ@mail.gmail.com>
References: <19450-bb0612c50c6786e5@postgresql.org> <CANWCAZYh-54rBucrL=tJQ5-UzRBUihZfS9wYtz=qUbhmuYJyxQ@mail.gmail.com>
Comments: In-reply-to John Naylor <johncnaylorls@gmail.com>
	message dated "Mon, 06 Apr 2026 09:43:00 +0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1197032.1775443854.1@sss.pgh.pa.us>
Date: Sun, 05 Apr 2026 22:50:54 -0400
Message-ID: <1197033.1775443854@sss.pgh.pa.us>
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Archived-At: <https://www.postgresql.org/message-id/1197033.1775443854%40sss.pgh.pa.us>
Precedence: bulk

John Naylor <johncnaylorls@gmail.com> writes:
>> There is no checksum_block.inc.c after master install

> I'll look into that. What broke, so I can reproduce?

src/include/Makefile knows what it's supposed to install out
of that subtree, and it thinks storage/*.h is sufficient.
I didn't check to see if the meson system has the same oversight.

One could argue that the real bug is having put a .c file into
the include/ tree in the first place.  Why was it done like that?
Couldn't it be a .h file?

			regards, tom lane