From: Tom Lane <tgl@sss.pgh.pa.us>
To: John Naylor <johncnaylorls@gmail.com>
cc: rekgrpth@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19450: Where is checksum_block.inc.c after master install?
In-reply-to: <CANWCAZbbegtd55eA7DwkkSAHPHyh4x-ZR=JyuLr37ZOD56h_8A@mail.gmail.com>
References: <19450-bb0612c50c6786e5@postgresql.org> <CANWCAZYh-54rBucrL=tJQ5-UzRBUihZfS9wYtz=qUbhmuYJyxQ@mail.gmail.com> <1197033.1775443854@sss.pgh.pa.us> <CANWCAZbbegtd55eA7DwkkSAHPHyh4x-ZR=JyuLr37ZOD56h_8A@mail.gmail.com>
Comments: In-reply-to John Naylor <johncnaylorls@gmail.com>
	message dated "Mon, 06 Apr 2026 09:57:40 +0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <1199321.1775444878.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Sun, 05 Apr 2026 23:07:58 -0400
Message-ID: <1199322.1775444878@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/1199322.1775444878%40sss.pgh.pa.us>
Precedence: bulk

John Naylor <johncnaylorls@gmail.com> writes:
> On Mon, Apr 6, 2026 at 9:50 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> One could argue that the real bug is having put a .c file into
>> the include/ tree in the first place.  Why was it done like that?
>> Couldn't it be a .h file?

> That was the way it was first coded. I thought of this way to avoid
> adding an exception to headerscheck. I can reverse that decision
> easily, but I may not get to it today.

Ah, the good ol' law of conservation of cruft.  But on the whole
I think naming it .h not .c is less crufty.  Agreed that there's
no great urgency about changing it.

			regards, tom lane