From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
cc: Thomas Munro <thomas.munro@gmail.com>, Andres Freund <andres@anarazel.de>,
        byavuz81@gmail.com,
        PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>,
        Heikki Linnakangas <heikki.linnakangas@iki.fi>,
        Michael Paquier <michael@paquier.xyz>
Subject: Re: BUG #17391: While using --with-ssl=openssl and
 PG_TEST_EXTRA='ssl' options, SSL tests fail on OpenBSD 7.0
In-reply-to: <9FC8618A-C651-4438-A6A3-7E6682944922@yesql.se>
References: <17391-304f81bcf724b58b@postgresql.org>
 <20220202213900.h7paogmcge2rtls6@alap3.anarazel.de>
 <CA+hUKGJ4+Ug16QU-PYGEZwUe2O69hdnCuyzLhMHHF02_uA4C5w@mail.gmail.com>
 <131329.1643851912@sss.pgh.pa.us> <203742.1643866877@sss.pgh.pa.us>
 <C44CE9FB-B37E-47D3-924B-4AF808AE98B1@yesql.se>
 <887CBA28-0942-4084-BE09-FBE0D6A1DB53@yesql.se>
 <621771.1644098845@sss.pgh.pa.us> <635760.1644108785@sss.pgh.pa.us>
 <9FC8618A-C651-4438-A6A3-7E6682944922@yesql.se>
Comments: In-reply-to Daniel Gustafsson <daniel@yesql.se>
	message dated "Tue, 08 Feb 2022 15:16:44 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1212292.1644347993.1@sss.pgh.pa.us>
Date: Tue, 08 Feb 2022 14:19:53 -0500
Message-ID: <1212293.1644347993@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1212293.1644347993%40sss.pgh.pa.us>
Precedence: bulk

Daniel Gustafsson <daniel@yesql.se> writes:
> On 6 Feb 2022, at 01:53, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I'd recommend using host='' in the tests, as that more or less
>> replicates what the test author probably expected to happen.

On second thought, using 'localhost' as in your original patch
might be better, simply so that we do exercise the call to
SSL_set_tlsext_host_name.

> Agreed. Are you taking care of that or should I?

It's your patch, feel free.

			regards, tom lane