From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
cc: jian he <jian.universality@gmail.com>, phb.emaj@free.fr,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18923: pg_dump 18beta1 fails to process complex table names
In-reply-to: <aCYumTym-wLvDFp8@nathan>
References: <18923-e79273f87c6bed69@postgresql.org>
 <37115.1747057899@sss.pgh.pa.us>
 <CACJufxFLUsXw2tsTLLvWSeO0cX=Wp+fnL-vKK7eiVu0=GSSnRA@mail.gmail.com>
 <aCYumTym-wLvDFp8@nathan>
Comments: In-reply-to Nathan Bossart <nathandbossart@gmail.com>
	message dated "Thu, 15 May 2025 14:12:41 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <12328.1747335801.1@sss.pgh.pa.us>
Date: Thu, 15 May 2025 15:03:21 -0400
Message-ID: <12329.1747335801@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/12329.1747335801%40sss.pgh.pa.us>
Precedence: bulk

Nathan Bossart <nathandbossart@gmail.com> writes:
> I don't think we want to teach appendPGArray() to handle single quotes.

No, that seems quite wrong.  array_in won't de-dup single quotes.

> My first instinct is that we need to build the array with appendPGArray()
> and then append it to the query using appendStringLiteralAH(), as done in
> the attached patch.

Yeah, I think so.  I was confused for a bit because the one extant
user of appendPGArray is getNamespaces which does an additional layer
of quote-doubling via quoteAclUserName.  However, that seems to be because
it's trying to build aclitem[] arrays whose elements will be read by
aclitemin, and that de-dups double quotes.

Wouldn't be a bad idea to add a test case.

			regards, tom lane