From: Ronan Dunklau <ronan.dunklau@aiven.io>
To: Noah Misch <noah@leadboat.com>
Cc: Michael Paquier <michael@paquier.xyz>,
 pgsql-bugs <pgsql-bugs@lists.postgresql.org>
Subject: Re: FSM Corruption (was: Could not read block at end of the relation)
Date: Mon, 15 Apr 2024 07:33:49 +0200
Message-ID: <12418161.O9o76ZdvQC@aivenlaptop>
In-Reply-To: <20240413171528.59.nmisch@google.com>
References: 
 <VtPLBUerbMM8BSDLQwIMV9Co_38iHS1TXE4V09x2ZVFhPkZMNE8LwgPSIzB8PHkVFXykGx04QNAzZVjJFAnU1w==@protonmail.internalid>
 <20240411153843.20@rfd.leadboat.com> <20240413171528.59.nmisch@google.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
Archived-At: 
 <https://www.postgresql.org/message-id/12418161.O9o76ZdvQC%40aivenlaptop>
Precedence: bulk

Le samedi 13 avril 2024, 19:15:28 CEST Noah Misch a =C3=A9crit :
> On Thu, Apr 11, 2024 at 08:38:43AM -0700, Noah Misch wrote:
> > On Thu, Apr 11, 2024 at 09:36:50AM +0200, Ronan Dunklau wrote:
> > > Le dimanche 7 avril 2024, 00:30:37 CEST Noah Misch a =C3=A9crit :
> > > > Your v3 has the right functionality.  As further confirmation of the
> > > > fix, I
> > > > tried reverting the non-test parts of commit 917dc7d "Fix WAL-loggi=
ng
> > > > of FSM and VM truncation".  That commit's 008_fsm_truncation.pl fai=
ls
> > > > with 917dc7d reverted from master, and adding this patch makes it
> > > > pass again.  I ran pgindent and edited comments.  I think the
> > > > attached version is ready to go.> >=20
> > > Thank you Noah, the updated comments are much better. I think it shou=
ld
> > > be
> > > backported at least to 16 since the chances of tripping on that
> > > behaviour are quite high here, but what about previous versions ?
> >=20
> > It should be reachable in all branches, just needing concurrent extensi=
on
> > lock waiters to reach before v16.  Hence, my plan is to back-patch it a=
ll
> > the way. It applies with negligible conflicts back to v12.
>=20
> While it applied, it doesn't build in v12 or v13, due to smgr_cached_nblo=
cks
> first appearing in c5315f4.  Options:
>=20
> 1. Back-patch the addition of smgr_cached_nblocks or equivalent.
> 2. Stop the back-patch of $SUBJECT at v14.
> 3. Incur more lseek() in v13 and v12.
>=20
> Given the lack of reports before v16, (3) seems too likely to be a cure
> worse than the disease.  I'm picking (2) for today.  We could do (1)
> tomorrow, but I lean toward (2) until someone reports the problem on v13 =
or
> v12.  The problem's impact is limited to DML giving ERROR when it should
> have succeeded, and I expect VACUUM FULL is a workaround.  Without those
> mitigating factors, I would choose (1).
>=20
> Pushed that way, as 9358297.

I agree with you that option 2 seems to be the safest course of action. For=
=20
the record, other available options when that happens is to stop PG and=20
manually remove the FSM from disk (see https://wiki.postgresql.org/wiki/
=46ree_Space_Map_Problems) or adapt the patch submitted here https://
www.postgresql.org/message-id/flat/5446938.Sb9uPGUboI%40aivenlaptop to do i=
t=20
online.=20

Thank you for all your work with refining, testing and finally comitting th=
e fix.

Best regards,

=2D-
Ronan Dunklau