From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Etsuro Fujita <etsuro.fujita@gmail.com>,
        Alexander Lakhin <exclusion@gmail.com>,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17828: postgres_fdw leaks file descriptors on error and
 aborts aborted transaction in lack of fds
In-reply-to: <20240208215920.myib264liwbkdndp@awork3.anarazel.de>
References: <17828-122da8cba23236be@postgresql.org>
 <423731.1678381075@sss.pgh.pa.us>
 <1adf8fee-5a9a-69c2-057a-87bbddebab9d@gmail.com>
 <CAPmGK15anMZdx_nYx8mTY+t0dPJiL3QFot-S4sGm7EJT_WnmhQ@mail.gmail.com>
 <CAPmGK15DF6EE7O6hTLbe5-fHvPDwEx9vm-BOCN3dsKOjZCo7bw@mail.gmail.com>
 <974582.1707411864@sss.pgh.pa.us>
 <20240208215920.myib264liwbkdndp@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Thu, 08 Feb 2024 13:59:20 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1258574.1707430006.1@sss.pgh.pa.us>
Date: Thu, 08 Feb 2024 17:06:46 -0500
Message-ID: <1258575.1707430006@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1258575.1707430006%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> I also wonder if postgres_fdw should strive to use a longer lived wait event
> set. For efficiency, if nothing else? That'd avoid the need to create one
> during error handling.

Seems like a plausible idea.  Having to acquire resources to clean up
an error is an anti-pattern for sure.

			regards, tom lane