From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Lakhin <exclusion@gmail.com>
cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16161: pg_ctl stop fails sometimes (on Windows)
In-reply-to: <5c7eaa87-8670-2008-3a15-337c133c12c2@gmail.com>
References: <4741.1576684991@sss.pgh.pa.us>
 <b2cc98b1-0ba0-1358-572f-8a1a01a3880e@gmail.com>
 <26441.1576706955@sss.pgh.pa.us>
 <20191219.103948.2182167132387989763.horikyota.ntt@gmail.com>
 <d32a75e6-ba99-c95c-e475-1887c009d395@gmail.com>
 <32374.1576770248@sss.pgh.pa.us>
 <5c7eaa87-8670-2008-3a15-337c133c12c2@gmail.com>
Comments: In-reply-to Alexander Lakhin <exclusion@gmail.com>
	message dated "Thu, 19 Dec 2019 23:00:00 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <12598.1576786185.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 19 Dec 2019 15:09:45 -0500
Message-ID: <12599.1576786185@sss.pgh.pa.us>
Precedence: bulk

Alexander Lakhin <exclusion@gmail.com> writes:
> Maybe we should change the condition to 'if (stat(fileName, &st) !=3D 0 =
&&
> (err =3D GetLastError()) =3D=3D ERROR_ACCESS_DENIED)' to avoid unnecessa=
ry
> sleep with a loop iteration...

Well, we have to loop back on file-not-found too ...

> It seems that the check for ERROR_DELETE_PENDING was added to
> pgwin32_safestat() blindly, the issue wasn't reproduced at that time:
> https://www.postgresql.org/message-id/CAB7nPqRJV6trFta-Qzgi6j2feuYR2ZC%2=
BKHvWdHnbpDG2scTrxw%40mail.gmail.com

Hmm, makes one wonder whether that's actually live code.

			regards, tom lane