Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1qHY2c-0002R4-O9
	for pgsql-bugs@arkaria.postgresql.org; Thu, 06 Jul 2023 23:05:38 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1qHY2Y-0000cs-Nu
	for pgsql-bugs@arkaria.postgresql.org; Thu, 06 Jul 2023 23:05:34 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1qHY2Y-0000ci-GB
	for pgsql-bugs@lists.postgresql.org; Thu, 06 Jul 2023 23:05:34 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1qHY2R-002cju-Af
	for pgsql-bugs@lists.postgresql.org; Thu, 06 Jul 2023 23:05:33 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 366N5Kd61264128;
	Thu, 6 Jul 2023 19:05:20 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jacob Champion <jchampion@timescale.com>
cc: Daniel Gustafsson <daniel@yesql.se>, Tobias Bussmann <t.bussmann@gmx.net>,
        Michael Paquier <michael@paquier.xyz>,
        Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
        Mark Guertin <markguertin@gmail.com>, pgsql-bugs@lists.postgresql.org
Subject: Re: pg_basebackup: errors on macOS on directories with ".DS_Store"
 files
In-reply-to: 
 <CAAWbhmi08E2okkCHjvhXtAdzqdFH+WPCbZzgRthDqVzL-HhiQw@mail.gmail.com>
References: <D816AB75-034A-4FF8-AF14-7AEAE61176C4@yesql.se>
 <ZEG9pTrrb5fdqRpS@paquier.xyz>
 <20230421.120220.1132981318960692233.horikyota.ntt@gmail.com>
 <7B26A7F6-375B-451A-8B6B-FD1CCA23FFEE@yesql.se>
 <ZEtahOGT60kql/rS@paquier.xyz>
 <D2C15F6D-D133-43D4-BC46-40120E605611@yesql.se>
 <ZEu21Ud7FitLiu7F@paquier.xyz>
 <1315ED16-F6C6-4346-9758-B048EDC9C1D1@yesql.se>
 <ZExZ510ZcfpZ5VdE@paquier.xyz>
 <121E6517-1644-4E6F-98CA-98EDC65202CC@yesql.se>
 <ZE9NXovq7cNLfPnM@paquier.xyz> <817432D1-864B-449F-B895-3A829ADE2A98@gmx.net>
 <0F3A9C7C-CEDA-45CC-9A75-9E2A17269324@yesql.se>
 <CAAWbhmi08E2okkCHjvhXtAdzqdFH+WPCbZzgRthDqVzL-HhiQw@mail.gmail.com>
Comments: In-reply-to Jacob Champion <jchampion@timescale.com>
	message dated "Thu, 06 Jul 2023 14:14:59 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1264126.1688684720.1@sss.pgh.pa.us>
Date: Thu, 06 Jul 2023 19:05:20 -0400
Message-ID: <1264127.1688684720@sss.pgh.pa.us>
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Archived-At: 
 <https://www.postgresql.org/message-id/1264127.1688684720%40sss.pgh.pa.us>
Precedence: bulk

Jacob Champion <jchampion@timescale.com> writes:
> My two cents: backpatching an exception for .DS_Store seems good, but
> creating an exclusion for all hidden files feels like a surprising
> change for stable branches.

On the whole, I think I'd vote for blocking .DS_Store only, even
in HEAD.  (IIRC, I thought differently to start with, but today
I'm feeling conservative about it.)  If there are other special
file names on other platforms, we could add some more targeted
exceptions; but dropping all hidden files seems more likely to
break things than be helpful.

			regards, tom lane