From: Tom Lane <tgl@sss.pgh.pa.us>
To: rekgrpth@gmail.com
cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18232: Function pushJsonbValueScalar has not
 Assert(scalarVal) on WJB_KEY, WJB_VALUE and WJB_ELEM
In-reply-to: <18232-27836d653eddfa97@postgresql.org>
References: <18232-27836d653eddfa97@postgresql.org>
Comments: In-reply-to PG Bug reporting form <noreply@postgresql.org>
	message dated "Thu, 07 Dec 2023 11:21:34 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1267886.1701959445.1@sss.pgh.pa.us>
Date: Thu, 07 Dec 2023 09:30:45 -0500
Message-ID: <1267887.1701959445@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1267887.1701959445%40sss.pgh.pa.us>
Precedence: bulk

PG Bug reporting form <noreply@postgresql.org> writes:
> Function pushJsonbValueScalar has not Assert(scalarVal) on WJB_KEY,
> WJB_VALUE and WJB_ELEM
> So I can call pushJsonbValue(NULL, WJB_VALUE, NULL) and get Segmentation
> fault

What's your point?  If we did have such Asserts, the process would
still crash if you did that.

In general I don't find a lot of value in Assert'ing that a pointer
isn't null in code that is about to dereference it.  You'll get a
clearly-interpretable process crash either way, so an Assert seems
like useless code bloat.  Others might have a different opinion,
but surely this is a matter of style not a bug.  We've not chosen
to have any particular project style on this point.

			regards, tom lane