From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Richard Guo <guofenglinux@gmail.com>, hysong0101@163.com,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17909: CREATE SCHEMA AUTHORIZATION sch CREATE TABLE foo ( id
 INT ) will coredump
In-reply-to: <ZEtD9rCQGXV10TWV@paquier.xyz>
References: <17909-f65c12dfc5f0451d@postgresql.org>
 <ZEolfwBHm6+znydH@paquier.xyz>
 <CAMbWs4-f5w+YCzqd90YAS-ogPxoahzfJ7C1QUUo8X+KE=0UC4w@mail.gmail.com>
 <ZEpA1SgNzEqhgCvA@paquier.xyz>
 <CAMbWs49CfOfrMp_AGPiBo7g7BusGf2gy1kGSatm-BYO5aeojvQ@mail.gmail.com>
 <ZEr/shjg+8TClUm/@paquier.xyz> <1237482.1682639329@sss.pgh.pa.us>
 <ZEsLq0ee/ZKwjf/r@paquier.xyz> <ZEskninhkXCQ5jZO@paquier.xyz>
 <CAMbWs49LjsDYOH5QejRKJyqYZSa2Q9j6LJ8Ae4zrvgMw-fYoEQ@mail.gmail.com>
 <ZEtD9rCQGXV10TWV@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Fri, 28 Apr 2023 12:56:38 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1273137.1682657619.1@sss.pgh.pa.us>
Date: Fri, 28 Apr 2023 00:53:39 -0400
Message-ID: <1273138.1682657619@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1273138.1682657619%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Fri, Apr 28, 2023 at 11:29:11AM +0800, Richard Guo wrote:
>> BTW, the comment states that CreateSchemaStmtContext.stmtType is "CREATE
>> SCHEMA" or "ALTER SCHEMA".   But it seems that there is no chance to set
>> it to "ALTER SCHEMA".  So should we update that comment, or go even
>> further to remove CreateSchemaStmtContext.stmtType since it is not used?

> Indeed.  I'd be OK with adjusting the comment, without removing
> stmtType to keep some consistency with CreateStmt, and it could be
> useful for debugging, perhaps..  (See 46379d6 as one origin point).

I'd be okay with just dropping that field.  It seems to be much
older than 46379d6, and if it ever had any real use it doesn't now.
(There's no ALTER SCHEMA in the SQL spec at all, let alone one that
has some overlap with CREATE SCHEMA options, so I don't foresee a
future use either.)

			regards, tom lane