From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tender Wang <tndrwang@gmail.com>
cc: tharakan@gmail.com, pgsql-bugs@lists.postgresql.org,
        Heikki Linnakangas <hlinnaka@iki.fi>
Subject: Re: BUG #18866: Running pg_freespace() on views triggers an Abort
In-reply-to: 
 <CAHewXNk6uX0VBROmoMrnKs_AOzbAQo+i9pouUiYj01y50HZRSw@mail.gmail.com>
References: <18866-d68926d0f1c72d44@postgresql.org>
 <CAHewXNk6uX0VBROmoMrnKs_AOzbAQo+i9pouUiYj01y50HZRSw@mail.gmail.com>
Comments: In-reply-to Tender Wang <tndrwang@gmail.com>
	message dated "Tue, 25 Mar 2025 23:45:07 +0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <1280896.1742920635.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 25 Mar 2025 12:37:15 -0400
Message-ID: <1280897.1742920635@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1280897.1742920635%40sss.pgh.pa.us>
Precedence: bulk

Tender Wang <tndrwang@gmail.com> writes:
> PG Bug reporting form <noreply@postgresql.org> =E4=BA=8E2025=E5=B9=B43=E6=
=9C=8825=E6=97=A5=E5=91=A8=E4=BA=8C 22:42=E5=86=99=E9=81=93=EF=BC=9A
>> Passing a view to pg_freespace() triggers an Abort on HEAD.

> I think we can remove the Assert in smgropen().
> Any thoughts?

That seems like a "solution" that will allow other bugs.  pg_freespace
should be fixed to verify RELKIND_HAS_STORAGE() before it tries to
access said storage.

			regards, tom lane