Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kzjDp-0006nv-Qp for pgsql-bugs@arkaria.postgresql.org; Wed, 13 Jan 2021 16:42:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kzjDo-0007sT-B8 for pgsql-bugs@arkaria.postgresql.org; Wed, 13 Jan 2021 16:42:12 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kzjDo-0007sM-56 for pgsql-bugs@lists.postgresql.org; Wed, 13 Jan 2021 16:42:12 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kzjDj-00047s-5R for pgsql-bugs@lists.postgresql.org; Wed, 13 Jan 2021 16:42:11 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 10DGg6vM1284343; Wed, 13 Jan 2021 11:42:06 -0500 From: Tom Lane To: ruga@protonmail.com cc: pgsql-bugs@lists.postgresql.org Subject: Re: BUG #16823: Unreachable code In-reply-to: <16823-e67a48abe06eccb9@postgresql.org> References: <16823-e67a48abe06eccb9@postgresql.org> Comments: In-reply-to PG Bug reporting form message dated "Wed, 13 Jan 2021 15:59:50 +0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1284341.1610556126.1@sss.pgh.pa.us> Date: Wed, 13 Jan 2021 11:42:06 -0500 Message-ID: <1284342.1610556126@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk PG Bug reporting form writes: > localtime.c:135:40: warning: code will never be executed > [-Wunreachable-code] > result -= !TWOS_COMPLEMENT(int32) && result != 0; > ^~~~~~ [ and much more in the same vein ] We're unlikely to change any of these, so I'd recommend turning off -Wunreachable-code. localtime.c is a clone of the IANA timezone code, so we're certainly not going to change it unless they do (which I doubt they would). bootparse.c, and some of the other files you mention, are code generated by bison, which we have no control over. Most of the rest of these are already manually commented as being unreachable; they're there partly for belt-and-suspenders reasons, and partly because some other compilers will warn if we don't have them. regards, tom lane