From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Thomas Munro <thomas.munro@gmail.com>,
        Etsuro Fujita <etsuro.fujita@gmail.com>,
        Alexander Lakhin <exclusion@gmail.com>,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17828: postgres_fdw leaks file descriptors on error and
 aborts aborted transaction in lack of fds
In-reply-to: <20240209004005.xu3lxvackgccpglg@awork3.anarazel.de>
References: <17828-122da8cba23236be@postgresql.org>
 <423731.1678381075@sss.pgh.pa.us>
 <1adf8fee-5a9a-69c2-057a-87bbddebab9d@gmail.com>
 <CAPmGK15anMZdx_nYx8mTY+t0dPJiL3QFot-S4sGm7EJT_WnmhQ@mail.gmail.com>
 <CAPmGK15DF6EE7O6hTLbe5-fHvPDwEx9vm-BOCN3dsKOjZCo7bw@mail.gmail.com>
 <974582.1707411864@sss.pgh.pa.us>
 <20240208215920.myib264liwbkdndp@awork3.anarazel.de>
 <1273950.1707436232@sss.pgh.pa.us>
 <20240209000734.st2xwkfsrz7izbnx@awork3.anarazel.de>
 <1278317.1707438035@sss.pgh.pa.us>
 <20240209004005.xu3lxvackgccpglg@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Thu, 08 Feb 2024 16:40:05 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1291436.1707444526.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 08 Feb 2024 21:08:46 -0500
Message-ID: <1291437.1707444526@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1291437.1707444526%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> I agree that we can't just delay cleanup till, potentially, much later ,=
 but I
> don't think that means that we have to wait 30s for each connection,
> one-by-one.

While that behavior is theoretically possible, I've heard no field
complaints about it actually happening.  I don't think we should
move heaven and earth to prevent it, barring some evidence of it
being a real-world issue.

ISTM we do need to do something about this AcquireExternalFD failure
though, because that's just self-inflicted damage.  (And I think it's
likely new since we invented WaitEventSets, though perhaps I'm wrong
about that.)

			regards, tom lane