Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jgwsz-0005CO-U6 for pgsql-bugs@arkaria.postgresql.org; Thu, 04 Jun 2020 20:54:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jgwsw-00059r-Ln for pgsql-bugs@arkaria.postgresql.org; Thu, 04 Jun 2020 20:54:46 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jgwsw-00059j-Fk for pgsql-bugs@lists.postgresql.org; Thu, 04 Jun 2020 20:54:46 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jgwst-0001Ci-Gj for pgsql-bugs@postgresql.org; Thu, 04 Jun 2020 20:54:45 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 054KsZ1i1313970; Thu, 4 Jun 2020 16:54:35 -0400 From: Tom Lane To: Christoph Berg cc: PostgreSQL Bugs Subject: Re: time values past 24:00:00 (or rather 23:59:60) In-reply-to: <6194.1590040381@sss.pgh.pa.us> References: <20200520125807.GB296739@msg.df7cb.de> <6194.1590040381@sss.pgh.pa.us> Comments: In-reply-to Tom Lane message dated "Thu, 21 May 2020 01:53:01 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1313968.1591304074.1@sss.pgh.pa.us> Date: Thu, 04 Jun 2020 16:54:34 -0400 Message-ID: <1313969.1591304074@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk I wrote: > Christoph Berg writes: >> This is not ok: >> # select '23:59:60.999'::time; >> time >> -------------- >> 24:00:00.999 > Yeah. Here's a draft patch for that (sans any regression tests as yet). I pushed this fix, but only as far back as v10. To apply it in the 9.x branches, we'd need to make the code support float timestamps, and I didn't think it was worth the trouble. regards, tom lane