From: Sergei Kornilov <sk@zsrv.org>
To: =?utf-8?B?0J7Qu9C10LMg0KHQsNC80L7QudC70L7Qsg==?= <splarv@ya.ru>
Cc: pgsql-bugs@lists.postgresql.org,
	=?utf-8?B?w4FsdmFybyBIZXJyZXJh?= <alvherre@kurilemu.de>
In-Reply-To: <9b9341b0-942e-4d34-b94f-92bd918fad04@ya.ru>
References: <202601301728.sfkizrto3t5i@alvherre.pgsql> <9b9341b0-942e-4d34-b94f-92bd918fad04@ya.ru>
Subject: Re: basic_archive lost archive_directory
MIME-Version: 1.0
Date: Fri, 06 Feb 2026 17:25:25 +0300
Message-Id: <1317421770387925@cea5cfd9-50d3-4d85-a924-a7cc75f8f215>
Content-Type: multipart/mixed;
	boundary="----==--bound.131743.a4b1fd0a-5640-4a25-ba72-55c0f5389dae"
Archived-At: <https://www.postgresql.org/message-id/1317421770387925%40cea5cfd9-50d3-4d85-a924-a7cc75f8f215>
Precedence: bulk


------==--bound.131743.a4b1fd0a-5640-4a25-ba72-55c0f5389dae
Content-Transfer-Encoding: 7bit
Content-Type: text/plain

Hello

How to reproduce:

1) configure

archive_mode = on
archive_library = 'basic_archive'
basic_archive.archive_directory = '/some/path/'

2) start postgres and verify archive works
3) make this directory temporary inaccessible. NFS will give you many ways to achieve this, here just mv /some/ /some_moved/  is enough.
4) basic_archive will complain ERROR:  could not create file ... No such file or directory for new WAL archive attempts
5) restart archiver process with any reason: kill it or restart postgres
6) make archive_directory accessible again: archiver process will not check the directory's existence again and continue to complain about unconfigured archive_directory

Maybe it makes sense to move the directory existence check from check_archive_directory (guc check callback) to basic_archive_configured? (attached)

regards, Sergei
------==--bound.131743.a4b1fd0a-5640-4a25-ba72-55c0f5389dae
Content-Disposition: attachment;
	filename="basic_archive_move_is_dir.patch"
Content-Transfer-Encoding: base64
Content-Type: text/x-diff;
	name="basic_archive_move_is_dir.patch"

ZGlmZiAtLWdpdCBhL2NvbnRyaWIvYmFzaWNfYXJjaGl2ZS9iYXNpY19hcmNoaXZlLmMgYi9jb250
cmliL2Jhc2ljX2FyY2hpdmUvYmFzaWNfYXJjaGl2ZS5jCmluZGV4IDZjN2Y5ODVkNDhiLi5kNDZh
YWIzOTgwNiAxMDA2NDQKLS0tIGEvY29udHJpYi9iYXNpY19hcmNoaXZlL2Jhc2ljX2FyY2hpdmUu
YworKysgYi9jb250cmliL2Jhc2ljX2FyY2hpdmUvYmFzaWNfYXJjaGl2ZS5jCkBAIC05NSw4ICs5
NSw2IEBAIF9QR19hcmNoaXZlX21vZHVsZV9pbml0KHZvaWQpCiBzdGF0aWMgYm9vbAogY2hlY2tf
YXJjaGl2ZV9kaXJlY3RvcnkoY2hhciAqKm5ld3ZhbCwgdm9pZCAqKmV4dHJhLCBHdWNTb3VyY2Ug
c291cmNlKQogewotCXN0cnVjdCBzdGF0IHN0OwotCiAJLyoKIAkgKiBUaGUgZGVmYXVsdCB2YWx1
ZSBpcyBhbiBlbXB0eSBzdHJpbmcsIHNvIHdlIGhhdmUgdG8gYWNjZXB0IHRoYXQgdmFsdWUuCiAJ
ICogT3VyIGNoZWNrX2NvbmZpZ3VyZWQgY2FsbGJhY2sgYWxzbyBjaGVja3MgZm9yIHRoaXMgYW5k
IHByZXZlbnRzCkBAIC0xMTUsMTcgKzExMyw2IEBAIGNoZWNrX2FyY2hpdmVfZGlyZWN0b3J5KGNo
YXIgKipuZXd2YWwsIHZvaWQgKipleHRyYSwgR3VjU291cmNlIHNvdXJjZSkKIAkJcmV0dXJuIGZh
bHNlOwogCX0KIAotCS8qCi0JICogRG8gYSBiYXNpYyBzYW5pdHkgY2hlY2sgdGhhdCB0aGUgc3Bl
Y2lmaWVkIGFyY2hpdmUgZGlyZWN0b3J5IGV4aXN0cy4gSXQKLQkgKiBjb3VsZCBiZSByZW1vdmVk
IGF0IHNvbWUgcG9pbnQgaW4gdGhlIGZ1dHVyZSwgc28gd2Ugc3RpbGwgbmVlZCB0byBiZQotCSAq
IHByZXBhcmVkIGZvciBpdCBub3QgdG8gZXhpc3QgaW4gdGhlIGFjdHVhbCBhcmNoaXZpbmcgbG9n
aWMuCi0JICovCi0JaWYgKHN0YXQoKm5ld3ZhbCwgJnN0KSAhPSAwIHx8ICFTX0lTRElSKHN0LnN0
X21vZGUpKQotCXsKLQkJR1VDX2NoZWNrX2VycmRldGFpbCgiU3BlY2lmaWVkIGFyY2hpdmUgZGly
ZWN0b3J5IGRvZXMgbm90IGV4aXN0LiIpOwotCQlyZXR1cm4gZmFsc2U7Ci0JfQotCiAJcmV0dXJu
IHRydWU7CiB9CiAKQEAgLTEzNywxMiArMTI0LDIzIEBAIGNoZWNrX2FyY2hpdmVfZGlyZWN0b3J5
KGNoYXIgKipuZXd2YWwsIHZvaWQgKipleHRyYSwgR3VjU291cmNlIHNvdXJjZSkKIHN0YXRpYyBi
b29sCiBiYXNpY19hcmNoaXZlX2NvbmZpZ3VyZWQoQXJjaGl2ZU1vZHVsZVN0YXRlICpzdGF0ZSkK
IHsKLQlpZiAoYXJjaGl2ZV9kaXJlY3RvcnkgIT0gTlVMTCAmJiBhcmNoaXZlX2RpcmVjdG9yeVsw
XSAhPSAnXDAnKQotCQlyZXR1cm4gdHJ1ZTsKKwlzdHJ1Y3Qgc3RhdCBzdDsKIAotCWFyY2hfbW9k
dWxlX2NoZWNrX2VycmRldGFpbCgiJXMgaXMgbm90IHNldC4iLAorCWlmIChhcmNoaXZlX2RpcmVj
dG9yeSA9PSBOVUxMIHx8IGFyY2hpdmVfZGlyZWN0b3J5WzBdID09ICdcMCcpCisJeworCQlhcmNo
X21vZHVsZV9jaGVja19lcnJkZXRhaWwoIiVzIGlzIG5vdCBzZXQuIiwKIAkJCQkJCQkJImJhc2lj
X2FyY2hpdmUuYXJjaGl2ZV9kaXJlY3RvcnkiKTsKLQlyZXR1cm4gZmFsc2U7CisKKwkJcmV0dXJu
IGZhbHNlOworCX0KKworCWlmIChzdGF0KGFyY2hpdmVfZGlyZWN0b3J5LCAmc3QpICE9IDAgfHwg
IVNfSVNESVIoc3Quc3RfbW9kZSkpCisJeworCQlhcmNoX21vZHVsZV9jaGVja19lcnJkZXRhaWwo
IlNwZWNpZmllZCBhcmNoaXZlIGRpcmVjdG9yeSBkb2VzIG5vdCBleGlzdC4iKTsKKwkJcmV0dXJu
IGZhbHNlOworCX0KKworCXJldHVybiB0cnVlOwogfQogCiAvKgo=
------==--bound.131743.a4b1fd0a-5640-4a25-ba72-55c0f5389dae--