From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jacob Champion <jacob.champion@enterprisedb.com>
cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        Daniel Schreiber <daniel.schreiber@hrz.tu-chemnitz.de>
Subject: Re: PostgreSQL 17: Bug in libpq when libpq is dlopened/closed multiple times
In-reply-to: <CAOYmi+=ezP7DSyTKh9xy3ejTxydrVicBYBYeoVZOWgYvAyjDxA@mail.gmail.com>
References: <f7fe39b3-7e99-4939-8852-07350549161d@hrz.tu-chemnitz.de> <CAOYmi+=e9bQQa1jgLqZ18m5w-7KA44VeL9FON6i2gd8bi=d5Jw@mail.gmail.com> <CAOYmi+kac3wEE3iqxHfHCNd_n2i-Or=n+Qk8_G24UZn2uz3DyQ@mail.gmail.com> <1309665.1776885833@sss.pgh.pa.us> <CAOYmi+=ezP7DSyTKh9xy3ejTxydrVicBYBYeoVZOWgYvAyjDxA@mail.gmail.com>
Comments: In-reply-to Jacob Champion <jacob.champion@enterprisedb.com>
	message dated "Wed, 22 Apr 2026 15:10:31 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <1329123.1776896008.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Wed, 22 Apr 2026 18:13:28 -0400
Message-ID: <1329124.1776896008@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/1329124.1776896008%40sss.pgh.pa.us>
Precedence: bulk

Jacob Champion <jacob.champion@enterprisedb.com> writes:
> On Wed, Apr 22, 2026 at 12:23 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Should we write the arguments as BIO_TYPE_NONE | BIO_TYPE_SOURCE_SINK
>> rather than just BIO_TYPE_SOURCE_SINK?

> Good question... Popularity-wise, the shorter spelling shows up across
> quite a few projects on GitHub, but the only spelling of
> `BIO_meth_new(BIO_TYPE_NONE | ...)` that I can find is a single place
> inside OpenSSL's own test suite -- which also uses the shorter
> alternative, in two places. So my vote is BIO_TYPE_SOURCE_SINK; we'll
> be in good company.

Fair enough.

			regards, tom lane